Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): update packages/language-service/build.sh script to work with vscode-ng-language-service's new Bazel build #48120

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 25 additions & 1 deletion packages/language-service/build.sh
Expand Up @@ -13,7 +13,31 @@ if [[ -z "${extension_repo}" ]]; then
exit 1
fi

# sedi makes `sed -i` work on both OSX & Linux
# See https://stackoverflow.com/questions/2320564/i-need-my-sed-i-command-for-in-place-editing-to-work-with-both-gnu-sed-and-bsd
_sedi () {
case $(uname) in
Darwin*) sedi=('-i' '') ;;
*) sedi=('-i') ;;
esac

sed "${sedi[@]}" "$@"
}

yarn bazel build --config=release //packages/language-service:npm_package
pushd "${extension_repo}"
yarn add @angular/language-service@file:"${bazel_bin}/packages/language-service/npm_package"
rm -rf .angular_packages/language-service
mkdir -p .angular_packages/language-service
cp -r "${bazel_bin}/packages/language-service/npm_package/" .angular_packages/language-service
chmod -R +w .angular_packages/language-service
cat <<EOT >> .angular_packages/language-service/BUILD.bazel
load("@aspect_rules_js//npm:defs.bzl", "npm_package")
npm_package(
name = "language-service",
srcs = glob(["**"], exclude = ["BUILD.bazel"]),
visibility = ["//visibility:public"],
)
EOT
_sedi 's#\# PLACE_HOLDER_FOR_packages/language-service/build.sh_IN_angular_REPO#data = ["//.angular_packages/language-service:package.json"], \# FOR TESTING ONLY! DO NOT COMMIT THIS LINE!#' WORKSPACE
yarn add @angular/language-service@file:".angular_packages/language-service"
popd