Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): add math elements to schema #55631

Closed
wants to merge 1 commit into from
Closed

fix(compiler): add math elements to schema #55631

wants to merge 1 commit into from
+84 −2

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 2, 2024

Fixes that we didn't have the MathML elements in the schema. Note that we can't discover which tag names are available by looking at globally-available classes, because all MathML elements are MathMLElement rather than something like SVGCircleElement. As such, I ended up having to hardcode the currently-available tags.

Fixes #55608.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: compiler Issues related to `ngc`, Angular's template compiler labels May 2, 2024
@ngbot ngbot bot modified the milestone: Backlog May 2, 2024
JoostK
JoostK approved these changes May 2, 2024
View reviewed changes
packages/compiler/test/schema/schema_extractor.ts Outdated Show resolved Hide resolved
packages/compiler/test/schema/schema_extractor.ts Outdated Show resolved Hide resolved
@crisbeto crisbeto force-pushed the 55608/math-schema branch 2 times, most recently from ae00a64 to 145736c Compare May 2, 2024 09:28
@crisbeto
fix(compiler): add math elements to schema
52a135f 
Fixes that we didn't have the MathML elements in the schema. Note that we can't discover which tag names are available by looking at globally-available classes, because all MathML elements are `MathMLElement` rather than something like `SVGCircleElement`. As such, I ended up having to hardcode the currently-available tags.

Fixes angular#55608.
@crisbeto crisbeto marked this pull request as ready for review May 2, 2024 11:53
jelbourn
jelbourn approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: fw-security

josephperrott
josephperrott approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: fw-security

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate and removed action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels May 2, 2024
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 2e891ad.

AndrewKushnir pushed a commit that referenced this pull request May 2, 2024
@crisbeto @AndrewKushnir
fix(compiler): add math elements to schema (#55631)
91b007e 
Fixes that we didn't have the MathML elements in the schema. Note that we can't discover which tag names are available by looking at globally-available classes, because all MathML elements are `MathMLElement` rather than something like `SVGCircleElement`. As such, I ended up having to hardcode the currently-available tags.

Fixes #55608.

PR Close #55631
crisbeto added a commit to crisbeto/angular that referenced this pull request May 2, 2024
@crisbeto
fix(compiler): add math elements to schema (angular#55631)
3dc0007 
Fixes that we didn't have the MathML elements in the schema. Note that we can't discover which tag names are available by looking at globally-available classes, because all MathML elements are `MathMLElement` rather than something like `SVGCircleElement`. As such, I ended up having to hardcode the currently-available tags.

Fixes angular#55608.

PR Close angular#55631
crisbeto added a commit to crisbeto/angular that referenced this pull request May 2, 2024
@crisbeto
fix(compiler): add math elements to schema (angular#55631)
46e0af7 
Fixes that we didn't have the MathML elements in the schema. Note that we can't discover which tag names are available by looking at globally-available classes, because all MathML elements are `MathMLElement` rather than something like `SVGCircleElement`. As such, I ended up having to hardcode the currently-available tags.

Fixes angular#55608.

PR Close angular#55631
@crisbeto crisbeto mentioned this pull request May 2, 2024
Closed
crisbeto added a commit to crisbeto/angular that referenced this pull request May 2, 2024
@crisbeto
fix(compiler): add math elements to schema (angular#55631)
184ec1c 
Fixes that we didn't have the MathML elements in the schema. Note that we can't discover which tag names are available by looking at globally-available classes, because all MathML elements are `MathMLElement` rather than something like `SVGCircleElement`. As such, I ended up having to hardcode the currently-available tags.

Fixes angular#55608.

PR Close angular#55631
AndrewKushnir pushed a commit that referenced this pull request May 2, 2024
@crisbeto @AndrewKushnir
fix(compiler): add math elements to schema (#55631) (#55645)
c21b459 
Fixes that we didn't have the MathML elements in the schema. Note that we can't discover which tag names are available by looking at globally-available classes, because all MathML elements are `MathMLElement` rather than something like `SVGCircleElement`. As such, I ended up having to hardcode the currently-available tags.

Fixes #55608.

PR Close #55631

PR Close #55645
This was referenced May 17, 2024
Open
Open
Open
@merfu merfu mentioned this pull request May 25, 2024
Open
This was referenced May 29, 2024
Merged
Merged
@ambrose40 ambrose40 mentioned this pull request May 29, 2024
Open
@aminekun90 aminekun90 mentioned this pull request May 30, 2024
Open
@Rosenstein Rosenstein mentioned this pull request May 31, 2024
Merged
This was referenced May 31, 2024
Open
Open
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoostK JoostK JoostK approved these changes

@jelbourn jelbourn jelbourn approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

MathML is unsupported
5 participants
@crisbeto @AndrewKushnir @JoostK @jelbourn @josephperrott