fix(material/chips): use checkmark graphic for single-selection #25890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For mat-chip-listbox, use the checkmark component for single-selection. Fixes issue where selected state is communicated visually only using color (angular#25886).
zarend
added
Accessibility
|
Creating a draft to test how feasible this is to land internally. |
|
@crisbeto I've converted this from draft to a PR, and it's ready for you eyes |
crisbeto
approved these changes
Nov 1, 2022
zarend
added a commit
that referenced
this pull request
Nov 3, 2022
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Nov 8, 2022
Fixes that chips that were selected programmatically, but were set as `selectable="false"` weren't showing the checkmark as intended in angular#25890. Also removes some of the logic now that we can assume that the checkmark will always be present.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For mat-chip-listbox, use the checkmark component for single-selection. Fixes issue where selected state is communicated visually only using color (#25886).