Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(shared-docs): remove xterm dependency #2043

Closed
wants to merge 1 commit into from
Closed

build(shared-docs): remove xterm dependency #2043

wants to merge 1 commit into from

Conversation

JeanMeche
Copy link
Member

xterm was the previous location of the same package.

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label May 2, 2024
josephperrott
josephperrott approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angular-robot angular-robot bot requested a review from josephperrott May 2, 2024 17:45
@JeanMeche JeanMeche changed the title build(shared-docs): The framework is relying on @xterm/xterm build(shared-docs): remove xterm dependency May 2, 2024
@JeanMeche JeanMeche mentioned this pull request May 2, 2024
Open
josephperrott
josephperrott approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label May 2, 2024
@angular-robot angular-robot bot requested a review from josephperrott May 2, 2024 18:42
@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels May 3, 2024
@alan-agius4
Copy link
Collaborator

@JeanMeche please rebase.

@JeanMeche
build(shared-docs): Remove the @xterm/xterm dependency
72d10eb 
components that use xterm aren't shared here.
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 3, 2024
josephperrott
josephperrott approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott
Copy link
Member

This PR was merged into the repository by commit ba8a5f8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JeanMeche @alan-agius4 @josephperrott