Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Spin size not correct when set fontSize #16569

Merged
merged 1 commit into from May 13, 2019
Merged

fix: Spin size not correct when set fontSize #16569

merged 1 commit into from May 13, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 13, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

close #15206

馃挕 Solution

Use em unit.

馃摑 Changelog

Fix Spin size not correct when set fontSize

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@codecov
Copy link

codecov bot commented May 13, 2019

Codecov Report

Merging #16569 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16569      +/-   ##
==========================================
+ Coverage   95.71%   95.75%   +0.04%     
==========================================
  Files         258      258              
  Lines        7120     7120              
  Branches     1970     2006      +36     
==========================================
+ Hits         6815     6818       +3     
+ Misses        303      300       -3     
  Partials        2        2
Impacted Files Coverage 螖
components/_util/wave.tsx 88.67% <0%> (+2.83%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3033b50...e556cb3. Read the comment docs.

@netlify
Copy link

netlify bot commented May 13, 2019

Deploy preview for ant-design ready!

Built with commit e556cb3

https://deploy-preview-16569--ant-design.netlify.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spin size not correct when set fontSize
1 participant