fix: Call Carousel force update when children lenght changed #16592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16592 +/- ##
==========================================
- Coverage 95.75% 95.71% -0.05%
==========================================
Files 258 258
Lines 7120 7123 +3
Branches 1970 2005 +35
==========================================
Hits 6818 6818
- Misses 300 303 +3
Partials 2 2
Continue to review full report at Codecov.
|
|
Deploy preview for ant-design ready! Built with commit 6dba711 |
|
excellent! |
rdmclin2
reviewed
May 15, 2019
| @@ -70,6 +71,12 @@ export default class Carousel extends React.Component<CarouselProps, {}> { | |||
| this.innerSlider = this.slick && this.slick.innerSlider; | |||
| } | |||
|
|
|||
| componentDidUpdate(prevProps: CarouselProps) { | |||
| if (React.Children.count(this.props.children) !== React.Children.count(prevProps.children)) { | |||
| this.goTo(0, false); | |||
There was a problem hiding this comment.
react-slick can set initialSlide prop锛宻hould goTo(0) be set to goTo(initialSlide)? https://react-slick.neostack.com/docs/api#initialSlide
There was a problem hiding this comment.
Greate~ Could you help to send a PR about this?
|
related: #16748 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 This is a ...
馃懟 What's the background?
fix #16583
馃挕 Solution
Call Carousel force update when children length changed
馃摑 Changelog
Fix Carousel miss active status when Children changed
鈽戯笍 Self Check before Merge