fix: 🐞 Fix selectedRows missing when there is childrenColumnName in Table #16616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afc163
commented
May 16, 2019
| @@ -1066,10 +1067,12 @@ export default class Table<T> extends React.Component<TableProps<T>, TableState< | |||
| } | |||
|
|
|||
| getFlatData() { | |||
| return flatArray(this.getLocalData(null, false)); | |||
| const { childrenColumnName } = this.props; | |||
| return flatArray(this.getLocalData(null, false), childrenColumnName); | |||
|
Deploy preview for ant-design ready! Built with commit c4128c0 |
Codecov Report
@@ Coverage Diff @@
## master #16616 +/- ##
==========================================
+ Coverage 95.7% 95.74% +0.04%
==========================================
Files 258 258
Lines 7125 7127 +2
Branches 2007 2007
==========================================
+ Hits 6819 6824 +5
+ Misses 304 301 -3
Partials 2 2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
👻 What's the background?
close #16614
💡 Solution
📝 Changelog
selectedRowsargument inonChangemissing when specifiedchildrenColumnName.onChange的selectedRows参数当指定了childrenColumnName时为空的问题。☑️ Self Check before Merge