New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: show version Number features were added #17373
docs: show version Number features were added #17373
Conversation
Deploy preview for ant-design ready! Built with commit 05fb204 |
May be affected by #17365. |
Codecov Report
@@ Coverage Diff @@
## master #17373 +/- ##
==========================================
+ Coverage 95.97% 96.01% +0.04%
==========================================
Files 263 263
Lines 7385 7385
Branches 2060 2022 -38
==========================================
+ Hits 7088 7091 +3
+ Misses 295 292 -3
Partials 2 2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #17373 +/- ##
=======================================
Coverage 96.04% 96.04%
=======================================
Files 267 267
Lines 7430 7430
Branches 2073 2034 -39
=======================================
Hits 7136 7136
Misses 292 292
Partials 2 2 Continue to review full report at Codecov.
|
🌚 又要rebase master了 |
notification 核对了一下,没啥问题了。 |
@afc163 这个PR现在还有什么问题吗? |
有冲突了。 |
等我喝瓶快乐水再干活 |
@afc163 done |
😢 怎么又冲突了 |
解决一下我今天合掉。 |
@afc163 冲突解决了 |
@muzea It seems that no need to add |
@dengfuping There are two considerations here.
|
@muzea IMO:
|
@dengfuping "3.0.0" just wants to express that every version in 3.x, this prop is available. It means that if leave it blank, will better express this meaning? |
Leaving |
@afc163 @dengfuping Removed meaningless “3.0.0”. |
🤔 This is a ...
👻 What's the background?
fix #17054
数据来源于文档中第一次出现的版本tag,会因为文档结构变化导致版本号计算错误。
rebase了一次master,整个人都不好了。
目前遗留的问题
notification/form 的类型因为有prop重名所以可能是不对的The data comes from the version tag that first appeared in the document, and the version number is incorrectly calculated due to changes in the document structure.
Rebase to the master is really too painful.
Current issues
notification/form may be incorrect because some prop name is duplicated.