Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: show version Number features were added #17373

Merged
merged 7 commits into from Jul 11, 2019
Merged

docs: show version Number features were added #17373

merged 7 commits into from Jul 11, 2019

Conversation

muzea
Copy link
Contributor

@muzea muzea commented Jun 29, 2019

🤔 This is a ...

  • Site / document update

👻 What's the background?

fix #17054

数据来源于文档中第一次出现的版本tag,会因为文档结构变化导致版本号计算错误。

rebase了一次master,整个人都不好了。
目前遗留的问题

  • notification/form 的类型因为有prop重名所以可能是不对的
  • 出现的3.19.8这个版本是因为有的修改没有发

The data comes from the version tag that first appeared in the document, and the version number is incorrectly calculated due to changes in the document structure.

Rebase to the master is really too painful.
Current issues

  • The type of notification/form may be incorrect because some prop name is duplicated.
  • The version 3.19.8 that appears is because Some modifications are not released now.

@netlify
Copy link

netlify bot commented Jun 29, 2019

Deploy preview for ant-design ready!

Built with commit 05fb204

https://deploy-preview-17373--ant-design.netlify.com

@muzea
Copy link
Contributor Author

muzea commented Jun 29, 2019

May be affected by #17365.

@codecov
Copy link

codecov bot commented Jun 29, 2019

Codecov Report

Merging #17373 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17373      +/-   ##
==========================================
+ Coverage   95.97%   96.01%   +0.04%     
==========================================
  Files         263      263              
  Lines        7385     7385              
  Branches     2060     2022      -38     
==========================================
+ Hits         7088     7091       +3     
+ Misses        295      292       -3     
  Partials        2        2
Impacted Files Coverage Δ
components/_util/wave.tsx 88.67% <0%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5f4956...8620065. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 29, 2019

Codecov Report

Merging #17373 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17373   +/-   ##
=======================================
  Coverage   96.04%   96.04%           
=======================================
  Files         267      267           
  Lines        7430     7430           
  Branches     2073     2034   -39     
=======================================
  Hits         7136     7136           
  Misses        292      292           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79bff3f...05fb204. Read the comment docs.

@muzea
Copy link
Contributor Author

muzea commented Jul 1, 2019

🌚 又要rebase master了

@muzea
Copy link
Contributor Author

muzea commented Jul 1, 2019

notification 核对了一下,没啥问题了。
form 东西比较多,粗略核对过是没啥问题的。

@muzea
Copy link
Contributor Author

muzea commented Jul 1, 2019

@afc163 这个PR现在还有什么问题吗?

@afc163
Copy link
Member

afc163 commented Jul 8, 2019

有冲突了。

@muzea
Copy link
Contributor Author

muzea commented Jul 8, 2019

等我喝瓶快乐水再干活

@muzea
Copy link
Contributor Author

muzea commented Jul 8, 2019

@afc163 done

@muzea
Copy link
Contributor Author

muzea commented Jul 9, 2019

😢 怎么又冲突了

@afc163
Copy link
Member

afc163 commented Jul 10, 2019

解决一下我今天合掉。

@muzea
Copy link
Contributor Author

muzea commented Jul 10, 2019

@afc163 冲突解决了

@dengfuping
Copy link
Contributor

@muzea It seems that no need to add 3.0.0 version. It's enough to just add special versions.

@muzea
Copy link
Contributor Author

muzea commented Jul 11, 2019

@dengfuping There are two considerations here.

  • Calculate which version of a prop is dependent on the structure of the document
  • Which specific version of a prop is added from 2.x or 1.x, which is of little significance to the current user

@dengfuping
Copy link
Contributor

@muzea IMO:

  • Documents of every major version is deployed separately.
  • Low readability for obvious version 3.0.0.

@muzea
Copy link
Contributor Author

muzea commented Jul 11, 2019

@dengfuping "3.0.0" just wants to express that every version in 3.x, this prop is available. It means that if leave it blank, will better express this meaning?

@afc163
Copy link
Member

afc163 commented Jul 11, 2019

Leaving meaningless 3.0.0 blank would be better, it make version information highlighted and easy to find.

@muzea
Copy link
Contributor Author

muzea commented Jul 11, 2019

@afc163 @dengfuping Removed meaningless “3.0.0”.

@afc163 afc163 merged commit fb0b4f0 into ant-design:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update website APIs to show version Number features were added.
3 participants