Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #17508 #17639

Merged
merged 2 commits into from Jul 15, 2019
Merged

Revert #17508 #17639

merged 2 commits into from Jul 15, 2019

Conversation

yesmeck
Copy link
Member

@yesmeck yesmeck commented Jul 15, 2019

This PR reverts #17508

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

回滚 #17508 中对 Input 后缀样式的修改,因其导致了其他更多问题。

Before #17508

Screen Shot 2019-07-15 at 2 37 22 PM

After #17508

Screen Shot 2019-07-15 at 2 37 25 PM

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English Revert change of Input suffix style in #17508, since it causes other problems
🇨🇳 Chinese 回滚 #17508 中对 Input 后缀样式的修改,因其导致了其他更多问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Jul 15, 2019

Deploy preview for ant-design ready!

Built with commit 61e0db5

https://deploy-preview-17639--ant-design.netlify.com

@yesmeck yesmeck changed the title Revert https://github.com/ant-design/ant-design/pull/17508 Revert #17508 Jul 15, 2019
@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #17639 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17639   +/-   ##
=======================================
  Coverage   96.04%   96.04%           
=======================================
  Files         267      267           
  Lines        7433     7433           
  Branches     2074     2062   -12     
=======================================
  Hits         7139     7139           
  Misses        292      292           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 491e388...61e0db5. Read the comment docs.

@zombieJ zombieJ merged commit 5b7c922 into master Jul 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the revert-input-fix branch July 15, 2019 07:04
@afc163 afc163 mentioned this pull request Jul 15, 2019
1 task
@afc163 afc163 mentioned this pull request Aug 7, 2019
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants