New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upload should not be aborted until handleRemove is resolved #18937
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
Deploy preview for ant-design ready! Built with commit f8f76c5 |
Codecov Report
@@ Coverage Diff @@
## feature #18937 +/- ##
===========================================
- Coverage 96.93% 96.93% -0.01%
===========================================
Files 281 281
Lines 7576 7572 -4
Branches 2073 2073
===========================================
- Hits 7344 7340 -4
Misses 230 230
Partials 2 2
Continue to review full report at Codecov.
|
e0c262a
to
a73d0af
Compare
a73d0af
to
68f5bd8
Compare
68f5bd8
to
f8f76c5
Compare
Is this resolved #15192 too? |
yes. |
This leads to a new problem. File. Status = '' removed "has been cancelled. The status of file in filelist cannot be obtained in the onremove function now. |
emm.. I'll check it later. |
This is another question raised by isuue (#15192 ). I got the correct state when binding the event to onchange |
@dazjean absolutely the file is NOT removed until function onRemove is resolved. that's why status is not |
🤔 This is a ...
🔗 Related issue link
#18902
💡 Background and solution
status and uploading progress of files should be kept as they are before the value of onRemove is resolved.
the solution is to toggle the status and quit the uploading while onRemove is resolved.
📝 Changelog
onRemove
determines upload abortingonRemove
对上传中断的控制☑️ Self Check before Merge