Add sortColumn to title render #19008
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add tree-select async demo * TreeSelect支持clearIcon和removeIcon * remove docs and demo * run test * clear code * add ui test
from typescript and documentation close #18847
|
Deploy preview for ant-design ready! Built with commit 454153c |
Codecov Report
@@ Coverage Diff @@
## feature #19008 +/- ##
===========================================
- Coverage 96.96% 96.92% -0.04%
===========================================
Files 281 281
Lines 7601 7555 -46
Branches 2136 2109 -27
===========================================
- Hits 7370 7323 -47
- Misses 229 230 +1
Partials 2 2
Continue to review full report at Codecov.
|
|
feature branch please~ |
@afc163 I changed the base branch to |
|
You need to checkout from feature then send PR to it. |
|
I have done this incorrectly, let me open a new PR |
|
New PR on feature branch here: #19012 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19007
🤔 This is a ...
🔗 Related issue link
#19007
Title render function is missing information about exactly which column is currently sorted. This is limiting when trying to render a custom sorter.
💡 Background and solution
Solution is to send the
sortColumnthat is stored in the table state. This way the user can infer which column is currently sorted while implementing thetitlerender function.📝 Changelog
Title render function argument object now contains a new key,
sortColumn.☑️ Self Check before Merge
View rendered components/table/index.en-US.md
View rendered components/table/index.zh-CN.md