fix: Typography warning for ref error
#19074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
|
Deploy preview for ant-design ready! Built with commit 637425c |
Codecov Report
@@ Coverage Diff @@
## master #19074 +/- ##
==========================================
- Coverage 97.38% 97.32% -0.06%
==========================================
Files 280 281 +1
Lines 7527 7548 +21
Branches 2063 2110 +47
==========================================
+ Hits 7330 7346 +16
- Misses 196 201 +5
Partials 1 1
Continue to review full report at Codecov.
|
shaodahong
reviewed
Oct 1, 2019
|
|
||
| let RefTypography; | ||
|
|
||
| if (React.forwardRef) { |
There was a problem hiding this comment.
一开始我是考虑 forwardRef 有兼容性问题，所以没有这样修，4.0 都不需要这样写，感觉需要个 to-do
There was a problem hiding this comment.
嗯，这些 4.0 发布后再清理就行了。否则每周 4.0 merge master 都一堆冲突。
|
新版 eslint-plugin-react 有 bug：jsx-eslint/eslint-plugin-react#2423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
fix #19064
ref #19066
💡 Background and solution
📝 Changelog
referror.ref的错误信息。☑️ Self Check before Merge