-
-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Typography warning for ref
error
#19074
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5266d41
Revert "fix: Typography funtion compoent use Ref console log warning …
zombieJ 58102d3
fix: Typography warning for ref
zombieJ ced0124
not crash on react 15
zombieJ 8d902cc
still use class if react15
zombieJ 6c2e4ed
fix ts define
zombieJ fd2a577
clean up
zombieJ 839e770
react 15 lock ref obj
zombieJ 637425c
Use rc-util findDOMNode instead
zombieJ File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import React from 'react'; | ||
|
||
export function fillRef<T>(ref: React.Ref<T>, node: T) { | ||
if (typeof ref === 'function') { | ||
ref(node); | ||
} else if (typeof ref === 'object' && ref) { | ||
(ref as any).current = node; | ||
} | ||
} | ||
|
||
export function composeRef<T>(...refs: React.Ref<T>[]): React.Ref<T> { | ||
return (node: T) => { | ||
refs.forEach(ref => { | ||
fillRef(ref, node); | ||
}); | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
一开始我是考虑
forwardRef
有兼容性问题,所以没有这样修,4.0 都不需要这样写,感觉需要个 to-doThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯,这些 4.0 发布后再清理就行了。否则每周 4.0 merge master 都一堆冲突。