Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table): The onChange sorter parameter always contains column info when the table is sorting/unsorting. #19226

Merged
merged 3 commits into from Oct 15, 2019

Conversation

yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Oct 15, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #19108

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English The onChange sorter parameter always contains column info when the table is sorting/unsorting.
🇨🇳 Chinese 现在 Table 排序时 onChange sorter 参数始终包含 column 信息。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Oct 15, 2019

Deploy preview for ant-design ready!

Built with commit 5a07b85

https://deploy-preview-19226--ant-design.netlify.com

@afc163
Copy link
Member

afc163 commented Oct 15, 2019

来个用例。

@afc163
Copy link
Member

afc163 commented Oct 15, 2019

- 取消排序时补充sorter信息到onChange callbak
+ 现在 Table 排序时 `onChange` `sorter` 参数始终包含 column 信息。

@yoyo837
Copy link
Contributor Author

yoyo837 commented Oct 15, 2019

我直接修改fires change event 用例应该就可以了吧?

@afc163
Copy link
Member

afc163 commented Oct 15, 2019

只要能保证和改动匹配到就行。

@afc163
Copy link
Member

afc163 commented Oct 15, 2019

英文 changelog 也改下。

@yoyo837 yoyo837 changed the title Provide additional args for onChange sorter when unsorting feat(Table): The onChange sorter parameter always contains column info when the table is sorting/unsorting. Oct 15, 2019
@yoyo837
Copy link
Contributor Author

yoyo837 commented Oct 15, 2019

components/menu/__tests__/index.test.js:179:74 Menu 咋还用例不过呢。

@yoyo837 yoyo837 merged commit 5a07b85 into master Oct 15, 2019
@yoyo837 yoyo837 deleted the add-args-unsorting branch October 15, 2019 09:54
@yoyo837
Copy link
Contributor Author

yoyo837 commented Oct 15, 2019

咦?我只是rebase一下 咋还自己merge了

@yoyo837
Copy link
Contributor Author

yoyo837 commented Oct 15, 2019

@afc163 变成另一个了

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table组件onChange中,当取消排序时sorter为{},能否增加传入column
2 participants