Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Table): The onChange sorter parameter always contains column info when the table is sorting/unsorting. #19226

Merged
merged 3 commits into from Oct 15, 2019
Merged

feat(Table): The onChange sorter parameter always contains column info when the table is sorting/unsorting. #19226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59685af
Provide additional args for onChange sorter when unsorting
yoyo837 Oct 15, 2019
0522d55
snapshot
yoyo837 Oct 15, 2019
5a07b85
upgrade `fires change event` test case
yoyo837 Oct 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 12 additions & 9 deletions components/config-provider/__tests__/__snapshots__/components.test.js.snap
View file
Open in desktop
Expand Up @@ -7998,6 +7998,7 @@ exports[`ConfigProvider components Mention prefixCls 1`] = `
exports[`ConfigProvider components Menu configProvider 1`] = `
<ul
class="config-menu config-menu-light config-menu-root config-menu-inline"
motion="[object Object]"
role="menu"
>
<li
Expand All @@ -8018,7 +8019,7 @@ exports[`ConfigProvider components Menu configProvider 1`] = `
/>
</div>
<ul
class="config-menu config-menu-sub config-menu-inline"
class="config-menu config-menu-sub config-menu-inline"
id="bamboo$Menu"
role="menu"
>
Expand Down Expand Up @@ -8051,6 +8052,7 @@ exports[`ConfigProvider components Menu configProvider 1`] = `
exports[`ConfigProvider components Menu normal 1`] = `
<ul
class="ant-menu ant-menu-light ant-menu-root ant-menu-inline"
motion="[object Object]"
role="menu"
>
<li
Expand All @@ -8071,7 +8073,7 @@ exports[`ConfigProvider components Menu normal 1`] = `
/>
</div>
<ul
class="ant-menu ant-menu-sub ant-menu-inline"
class="ant-menu ant-menu-sub ant-menu-inline"
id="bamboo$Menu"
role="menu"
>
Expand Down Expand Up @@ -8104,6 +8106,7 @@ exports[`ConfigProvider components Menu normal 1`] = `
exports[`ConfigProvider components Menu prefixCls 1`] = `
<ul
class="prefix-Menu prefix-Menu-light prefix-Menu-root prefix-Menu-inline"
motion="[object Object]"
role="menu"
>
<li
Expand All @@ -8124,7 +8127,7 @@ exports[`ConfigProvider components Menu prefixCls 1`] = `
/>
</div>
<ul
class="prefix-Menu prefix-Menu-sub prefix-Menu-inline"
class="prefix-Menu prefix-Menu-sub prefix-Menu-inline"
id="bamboo$Menu"
role="menu"
>
Expand Down Expand Up @@ -11142,7 +11145,7 @@ exports[`ConfigProvider components Slider configProvider 1`] = `
/>
<div
class="config-slider-track"
style="left:0%;right:auto;width:0%"
style="left:0%;width:0%"
/>
<div
class="config-slider-step"
Expand All @@ -11154,7 +11157,7 @@ exports[`ConfigProvider components Slider configProvider 1`] = `
aria-valuenow="0"
class="config-slider-handle config-tooltip-open"
role="slider"
style="left:0%;right:auto;transform:translateX(-50%)"
style="left:0%"
tabindex="0"
/>
<div>
Expand Down Expand Up @@ -11191,7 +11194,7 @@ exports[`ConfigProvider components Slider normal 1`] = `
/>
<div
class="ant-slider-track"
style="left:0%;right:auto;width:0%"
style="left:0%;width:0%"
/>
<div
class="ant-slider-step"
Expand All @@ -11203,7 +11206,7 @@ exports[`ConfigProvider components Slider normal 1`] = `
aria-valuenow="0"
class="ant-slider-handle ant-tooltip-open"
role="slider"
style="left:0%;right:auto;transform:translateX(-50%)"
style="left:0%"
tabindex="0"
/>
<div>
Expand Down Expand Up @@ -11240,7 +11243,7 @@ exports[`ConfigProvider components Slider prefixCls 1`] = `
/>
<div
class="prefix-Slider-track"
style="left:0%;right:auto;width:0%"
style="left:0%;width:0%"
/>
<div
class="prefix-Slider-step"
Expand All @@ -11252,7 +11255,7 @@ exports[`ConfigProvider components Slider prefixCls 1`] = `
aria-valuenow="0"
class="prefix-Slider-handle prefix-Slider-tooltip-open"
role="slider"
style="left:0%;right:auto;transform:translateX(-50%)"
style="left:0%"
tabindex="0"
/>
<div>
Expand Down
16 changes: 8 additions & 8 deletions components/form/__tests__/__snapshots__/demo.test.js.snap
View file
Open in desktop
Expand Up @@ -3343,7 +3343,7 @@ exports[`renders ./components/form/demo/validate-other.md correctly 1`] = `
/>
<div
class="ant-slider-track"
style="left:0%;right:auto;width:0%"
style="left:0%;width:0%"
/>
<div
class="ant-slider-step"
Expand Down Expand Up @@ -3380,45 +3380,45 @@ exports[`renders ./components/form/demo/validate-other.md correctly 1`] = `
aria-valuenow="0"
class="ant-slider-handle"
role="slider"
style="left:0%;right:auto;transform:translateX(-50%)"
style="left:0%"
tabindex="0"
/>
<div
class="ant-slider-mark"
>
<span
class="ant-slider-mark-text ant-slider-mark-text-active"
style="transform:translateX(-50%);-ms-transform:translateX(-50%);left:0%"
style="left:0%;transform:translateX(-50%);-ms-transform:translateX(-50%)"
>
A
</span>
<span
class="ant-slider-mark-text"
style="transform:translateX(-50%);-ms-transform:translateX(-50%);left:20%"
style="left:20%;transform:translateX(-50%);-ms-transform:translateX(-50%)"
>
B
</span>
<span
class="ant-slider-mark-text"
style="transform:translateX(-50%);-ms-transform:translateX(-50%);left:40%"
style="left:40%;transform:translateX(-50%);-ms-transform:translateX(-50%)"
>
C
</span>
<span
class="ant-slider-mark-text"
style="transform:translateX(-50%);-ms-transform:translateX(-50%);left:60%"
style="left:60%;transform:translateX(-50%);-ms-transform:translateX(-50%)"
>
D
</span>
<span
class="ant-slider-mark-text"
style="transform:translateX(-50%);-ms-transform:translateX(-50%);left:80%"
style="left:80%;transform:translateX(-50%);-ms-transform:translateX(-50%)"
>
E
</span>
<span
class="ant-slider-mark-text"
style="transform:translateX(-50%);-ms-transform:translateX(-50%);left:100%"
style="left:100%;transform:translateX(-50%);-ms-transform:translateX(-50%)"
>
F
</span>
Expand Down
48 changes: 24 additions & 24 deletions components/grid/__tests__/__snapshots__/demo.test.js.snap
View file
Open in desktop
Expand Up @@ -525,7 +525,7 @@ exports[`renders ./components/grid/demo/playground.md correctly 1`] = `
/>
<div
class="ant-slider-track"
style="left:0%;right:auto;width:20%"
style="left:0%;width:20%"
/>
<div
class="ant-slider-step"
Expand Down Expand Up @@ -562,45 +562,45 @@ exports[`renders ./components/grid/demo/playground.md correctly 1`] = `
aria-valuenow="1"
class="ant-slider-handle"
role="slider"
style="left:20%;right:auto;transform:translateX(-50%)"
style="left:20%"
tabindex="0"
/>
<div
class="ant-slider-mark"
>
<span
class="ant-slider-mark-text ant-slider-mark-text-active"
style="transform:translateX(-50%);-ms-transform:translateX(-50%);left:0%"
style="left:0%;transform:translateX(-50%);-ms-transform:translateX(-50%)"
>
8
</span>
<span
class="ant-slider-mark-text ant-slider-mark-text-active"
style="transform:translateX(-50%);-ms-transform:translateX(-50%);left:20%"
style="left:20%;transform:translateX(-50%);-ms-transform:translateX(-50%)"
>
16
</span>
<span
class="ant-slider-mark-text"
style="transform:translateX(-50%);-ms-transform:translateX(-50%);left:40%"
style="left:40%;transform:translateX(-50%);-ms-transform:translateX(-50%)"
>
24
</span>
<span
class="ant-slider-mark-text"
style="transform:translateX(-50%);-ms-transform:translateX(-50%);left:60%"
style="left:60%;transform:translateX(-50%);-ms-transform:translateX(-50%)"
>
32
</span>
<span
class="ant-slider-mark-text"
style="transform:translateX(-50%);-ms-transform:translateX(-50%);left:80%"
style="left:80%;transform:translateX(-50%);-ms-transform:translateX(-50%)"
>
40
</span>
<span
class="ant-slider-mark-text"
style="transform:translateX(-50%);-ms-transform:translateX(-50%);left:100%"
style="left:100%;transform:translateX(-50%);-ms-transform:translateX(-50%)"
>
48
</span>
Expand All @@ -623,7 +623,7 @@ exports[`renders ./components/grid/demo/playground.md correctly 1`] = `
/>
<div
class="ant-slider-track"
style="left:0%;right:auto;width:20%"
style="left:0%;width:20%"
/>
<div
class="ant-slider-step"
Expand Down Expand Up @@ -660,45 +660,45 @@ exports[`renders ./components/grid/demo/playground.md correctly 1`] = `
aria-valuenow="1"
class="ant-slider-handle"
role="slider"
style="left:20%;right:auto;transform:translateX(-50%)"
style="left:20%"
tabindex="0"
/>
<div
class="ant-slider-mark"
>
<span
class="ant-slider-mark-text ant-slider-mark-text-active"
style="transform:translateX(-50%);-ms-transform:translateX(-50%);left:0%"
style="left:0%;transform:translateX(-50%);-ms-transform:translateX(-50%)"
>
8
</span>
<span
class="ant-slider-mark-text ant-slider-mark-text-active"
style="transform:translateX(-50%);-ms-transform:translateX(-50%);left:20%"
style="left:20%;transform:translateX(-50%);-ms-transform:translateX(-50%)"
>
16
</span>
<span
class="ant-slider-mark-text"
style="transform:translateX(-50%);-ms-transform:translateX(-50%);left:40%"
style="left:40%;transform:translateX(-50%);-ms-transform:translateX(-50%)"
>
24
</span>
<span
class="ant-slider-mark-text"
style="transform:translateX(-50%);-ms-transform:translateX(-50%);left:60%"
style="left:60%;transform:translateX(-50%);-ms-transform:translateX(-50%)"
>
32
</span>
<span
class="ant-slider-mark-text"
style="transform:translateX(-50%);-ms-transform:translateX(-50%);left:80%"
style="left:80%;transform:translateX(-50%);-ms-transform:translateX(-50%)"
>
40
</span>
<span
class="ant-slider-mark-text"
style="transform:translateX(-50%);-ms-transform:translateX(-50%);left:100%"
style="left:100%;transform:translateX(-50%);-ms-transform:translateX(-50%)"
>
48
</span>
Expand All @@ -721,7 +721,7 @@ exports[`renders ./components/grid/demo/playground.md correctly 1`] = `
/>
<div
class="ant-slider-track"
style="left:0%;right:auto;width:40%"
style="left:0%;width:40%"
/>
<div
class="ant-slider-step"
Expand Down Expand Up @@ -758,45 +758,45 @@ exports[`renders ./components/grid/demo/playground.md correctly 1`] = `
aria-valuenow="2"
class="ant-slider-handle"
role="slider"
style="left:40%;right:auto;transform:translateX(-50%)"
style="left:40%"
tabindex="0"
/>
<div
class="ant-slider-mark"
>
<span
class="ant-slider-mark-text ant-slider-mark-text-active"
style="transform:translateX(-50%);-ms-transform:translateX(-50%);left:0%"
style="left:0%;transform:translateX(-50%);-ms-transform:translateX(-50%)"
>
2
</span>
<span
class="ant-slider-mark-text ant-slider-mark-text-active"
style="transform:translateX(-50%);-ms-transform:translateX(-50%);left:20%"
style="left:20%;transform:translateX(-50%);-ms-transform:translateX(-50%)"
>
3
</span>
<span
class="ant-slider-mark-text ant-slider-mark-text-active"
style="transform:translateX(-50%);-ms-transform:translateX(-50%);left:40%"
style="left:40%;transform:translateX(-50%);-ms-transform:translateX(-50%)"
>
4
</span>
<span
class="ant-slider-mark-text"
style="transform:translateX(-50%);-ms-transform:translateX(-50%);left:60%"
style="left:60%;transform:translateX(-50%);-ms-transform:translateX(-50%)"
>
6
</span>
<span
class="ant-slider-mark-text"
style="transform:translateX(-50%);-ms-transform:translateX(-50%);left:80%"
style="left:80%;transform:translateX(-50%);-ms-transform:translateX(-50%)"
>
8
</span>
<span
class="ant-slider-mark-text"
style="transform:translateX(-50%);-ms-transform:translateX(-50%);left:100%"
style="left:100%;transform:translateX(-50%);-ms-transform:translateX(-50%)"
>
12
</span>
Expand Down