Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Fix Table filter menu have no height #23272

Merged
merged 1 commit into from Apr 15, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Apr 15, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #23166

💡 Background and solution

when less version is 2.x

📝 Changelog

Language Changelog
🇺🇸 English Fix Table filter menu no height when less version is 2.x.
🇨🇳 Chinese 修复 Table 筛选菜单在 less 版本为 2.x 时不显示的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

when less version is 2.x

close #23166
@afc163 afc163 changed the title 🐛 Fix Table filter menu have no height fix: 🐛 Fix Table filter menu have no height Apr 15, 2020
@@ -447,7 +447,7 @@
.@{ant-prefix}-dropdown-menu {
// https://github.com/ant-design/ant-design/issues/4916
// https://github.com/ant-design/ant-design/issues/19542
max-height: calc(100vh - 130px);
max-height: ~'calc(100vh - 130px)';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less 2 不支持上面的写法。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max-height: calc(~'100vh - 130px'); 这种是不是也是less 2支持的?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不了解,可以试试。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

试了下好像都可以,less 2/3也都支持这种

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本质上和当前的改法是一样的。

@afc163 afc163 merged commit 56870dd into 3.x-stable Apr 15, 2020
@afc163 afc163 deleted the fix-table-filter-menu branch April 15, 2020 02:50
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7f38c6a:

Sandbox Source
antd reproduction template Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants