Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 Fix Table filter menu have no height #23272

Merged
merged 1 commit into from Apr 15, 2020
Merged

fix: 🐛 Fix Table filter menu have no height #23272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/table/style/index.less
View file
Open in desktop
Expand Up @@ -447,7 +447,7 @@
.@{ant-prefix}-dropdown-menu {
// https://github.com/ant-design/ant-design/issues/4916
// https://github.com/ant-design/ant-design/issues/19542
max-height: calc(100vh - 130px);
max-height: ~'calc(100vh - 130px)';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less 2 不支持上面的写法。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max-height: calc(~'100vh - 130px'); 这种是不是也是less 2支持的？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不了解，可以试试。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

试了下好像都可以，less 2/3也都支持这种

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本质上和当前的改法是一样的。

overflow-x: hidden;
border: 0;
border-radius: @border-radius-base @border-radius-base 0 0;
Expand Down