Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Result should hide icon when it is falsy #38488

Merged
merged 1 commit into from Nov 10, 2022
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Nov 10, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #38484

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Result should hide icon when it is falsy.
🇨🇳 Chinese 修复 Result iconnull 时图标没有隐藏的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163 afc163 marked this pull request as ready for review November 10, 2022 11:04
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball: LGTM! 👍

confidence: 1.00 | [dashboard]

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2022

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball: LGTM! 👍

confidence: 1.00 | [dashboard]

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball: LGTM! 👍

confidence: 1.00 | [dashboard]

@github-actions
Copy link
Contributor

Size Change: +15 B (0%)

Total Size: 963 kB

Filename Size Change
./dist/antd-with-locales.min.js 374 kB +8 B (0%)
./dist/antd.min.js 317 kB +7 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/antd.compact.min.css 67.7 kB
./dist/antd.dark.min.css 69 kB
./dist/antd.min.css 67.6 kB
./dist/antd.variable.min.css 68.3 kB

compressed-size-action

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 99.98% // Head: 100.00% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (b588bce) compared to base (8af0b4f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #38488      +/-   ##
===========================================
+ Coverage   99.98%   100.00%   +0.01%     
===========================================
  Files         447       447              
  Lines        8312      8314       +2     
  Branches     2530      2531       +1     
===========================================
+ Hits         8311      8314       +3     
+ Misses          1         0       -1     
Impacted Files Coverage Δ
components/result/index.tsx 100.00% <100.00%> (ø)
components/tooltip/index.tsx 100.00% <0.00%> (+1.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit 0746249 into master Nov 10, 2022
@afc163 afc163 deleted the fix/result-icon branch November 10, 2022 11:27
elevensky pushed a commit to elevensky/ant-design that referenced this pull request Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "showIcon" property on "Result"
1 participant