Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add classNames and styles prop for card #46276

Closed
wants to merge 26 commits into from

Conversation

zh-lx
Copy link
Contributor

@zh-lx zh-lx commented Dec 5, 2023

close #46260

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

#46260

💡 Background and solution

Add classNames and styles prop for card

📝 Changelog

Add classNames and styles prop for card

Language Changelog
🇺🇸 English Add classNames and styles prop for card
🇨🇳 Chinese Card 组件增加 classNames 和 styles 属性

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Dec 5, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Preview Is ready

Copy link

codesandbox-ci bot commented Dec 5, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6148f51:

Sandbox Source
antd reproduction template (forked) Configuration

components/card/Card.tsx Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca39a4b) 100.00% compared to head (89aa377) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #46276   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          731       731           
  Lines        12545     12567   +22     
  Branches      3287      3293    +6     
=========================================
+ Hits         12545     12567   +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan
Copy link
Member

feature branch

components/card/Card.tsx Outdated Show resolved Hide resolved
components/card/Card.tsx Outdated Show resolved Hide resolved
components/card/Card.tsx Outdated Show resolved Hide resolved
@li-jia-nan
Copy link
Member

feature 分支

Copy link
Contributor

github-actions bot commented Dec 11, 2023

Visual Regression Report for PR #46276 Passed ✅

Target branch: feature (ca39a4b)


Congrats! No visual-regression diff found

@afc163 afc163 requested a review from MadCcc December 25, 2023 15:47
@zh-lx zh-lx requested a review from afc163 December 29, 2023 06:32
@afc163 afc163 removed their request for review December 29, 2023 10:57
@zh-lx zh-lx requested a review from afc163 January 3, 2024 03:02
@afc163
Copy link
Member

afc163 commented Jan 3, 2024

@MadCcc

@zh-lx zh-lx changed the base branch from master to feature January 5, 2024 00:40
components/card/Card.tsx Show resolved Hide resolved
components/card/index.zh-CN.md Outdated Show resolved Hide resolved
@zh-lx zh-lx requested a review from MadCcc January 5, 2024 02:58
@li-jia-nan
Copy link
Member

冲突看一下

Signed-off-by: zhoulixiang <18366276315@163.com>
@zh-lx
Copy link
Contributor Author

zh-lx commented Jan 5, 2024

冲突看一下

done!

Copy link
Contributor

github-actions bot commented Jan 5, 2024

Hi @zh-lx. Thanks for your contribution. The path .github/ or scripts/ and CHANGELOG is only maintained by team members. This current PR will be closed and team members will help on this.

@zh-lx
Copy link
Contributor Author

zh-lx commented Jan 5, 2024

@afc163 @MadCcc

Hi @zh-lx. Thanks for your contribution. The path .github/ or scripts/ and CHANGELOG is only maintained by team members. This current PR will be closed and team members will help on this.

I change the table count of card in scripts/check-site.snap. It directly be closed by bot. 😂

@zh-lx
Copy link
Contributor Author

zh-lx commented Jan 5, 2024

Create a new PR #46811 , this PR is deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add className for inner child div's of components (i.e Card)
7 participants