Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add classNames and styles prop for card #46811

Merged
merged 34 commits into from Jan 30, 2024

Conversation

zh-lx
Copy link
Contributor

@zh-lx zh-lx commented Jan 5, 2024

A new PR from #46276. close #46260

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

#46260

💡 Background and solution

Add classNames and styles prop for card

📝 Changelog

Add classNames and styles prop for card

Language Changelog
🇺🇸 English Add classNames and styles prop for card
🇨🇳 Chinese Card 组件增加 classNames 和 styles 属性

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 5, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 5, 2024

Visual Regression Report for PR #46811 Passed ✅

Target branch: feature (5031ca9)


Congrats! No visual-regression diff found

@zh-lx zh-lx changed the base branch from master to feature January 5, 2024 06:02
Copy link
Contributor

github-actions bot commented Jan 5, 2024

Preview Is ready

Copy link

codesandbox-ci bot commented Jan 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 492705f:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5031ca9) 100.00% compared to head (492705f) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #46811   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          734       734           
  Lines        12557     12579   +22     
  Branches      3282      3288    +6     
=========================================
+ Hits         12557     12579   +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zh-lx
Copy link
Contributor Author

zh-lx commented Jan 5, 2024

I add a new table for styles and classNames in markdown of Card. And need you change 3 to 4 in scripts/snapshots/check-site.ts.snap#L43-L45 @Wxh16144 @MadCcc

@MadCcc
Copy link
Member

MadCcc commented Jan 5, 2024

You can update snapshot now, we've disabled bot.

@zh-lx
Copy link
Contributor Author

zh-lx commented Jan 5, 2024

You can update snapshot now, we've disabled bot.

done❤

@afc163 afc163 requested a review from MadCcc January 8, 2024 03:22
@afc163
Copy link
Member

afc163 commented Jan 16, 2024

@MadCcc ping~

@zh-lx
Copy link
Contributor Author

zh-lx commented Jan 25, 2024

@MadCcc Ping一下大佬

@afc163
Copy link
Member

afc163 commented Jan 27, 2024

冲突了

Signed-off-by: zhoulixiang <18366276315@163.com>
@zh-lx
Copy link
Contributor Author

zh-lx commented Jan 28, 2024

冲突了

resolved~

@zh-lx zh-lx requested a review from li-jia-nan January 29, 2024 06:32
@MadCcc MadCcc merged commit 6ed0254 into ant-design:feature Jan 30, 2024
61 checks passed
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add className for inner child div's of components (i.e Card)
6 participants