Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Menu): Fixed a major issue with the floating style and triggering… #47221

Closed
wants to merge 1 commit into from

Conversation

kampiu
Copy link
Contributor

@kampiu kampiu commented Jan 29, 2024

… area of vertical menus being different under secondary menus.

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

#47143

💡 Background and solution

截屏2024-01-30 03 42 06

📝 Changelog

Language Changelog
🇺🇸 English By adjusting the background color of the child level when the non horizontal mode submenu is activated, the expected effect is forcibly constrained.
🇨🇳 Chinese 通过调整非横向模式下子菜单被激活时的子级背景色强制约束预期效果。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

… area of vertical menus being different under secondary menus.
Copy link

stackblitz bot commented Jan 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 29, 2024

Preview Is ready

Copy link
Contributor

github-actions bot commented Jan 29, 2024

Visual Regression Report for PR #47221 Passed ✅

Target branch: master (c61870e)


Congrats! No visual-regression diff found

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 83b984b:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c61870e) 100.00% compared to head (83b984b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47221   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          732       732           
  Lines        12563     12563           
  Branches      3295      3295           
=========================================
  Hits         12563     12563           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc mentioned this pull request Jan 30, 2024
20 tasks
@MadCcc
Copy link
Member

MadCcc commented Jan 30, 2024

Better solution here: #47227

@kampiu
Copy link
Contributor Author

kampiu commented Jan 30, 2024

Better solution here: #47227

Is this done by making the pop-up position of the submenu closer to the floating area

@MadCcc
Copy link
Member

MadCcc commented Jan 30, 2024

Is this done by making the pop-up position of the submenu closer to the floating area

Submenu did have a pseudo element to make it close to trigger, but the position was wrong before.

@kampiu kampiu closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants