Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Menu submenu hover style #47227

Merged
merged 2 commits into from Jan 30, 2024
Merged

fix: Menu submenu hover style #47227

merged 2 commits into from Jan 30, 2024

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Jan 30, 2024

  • fix: Menu submenu hover style
  • chore: code clean

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

resolve #47143

close #47221

💡 Background and solution

#42648 中 Menu 的子菜单不再通过 align 对齐,所以一些 hardcode 可以删除了。

📝 Changelog

Language Changelog
🇺🇸 English Fix Menu that submenu hover style disappear when hover on the edge.
🇨🇳 Chinese 修复 Menu 组件子菜单 hover 样式在边缘消失的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 30, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 30, 2024

Visual Regression Report for PR #47227 Passed ✅

Target branch: master (441ba5f)


Congrats! No visual-regression diff found

Copy link
Contributor

github-actions bot commented Jan 30, 2024

Preview Is ready

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 331.41 KB (-102 B 🔽)
./dist/antd-with-locales.min.js 377.14 KB (-348 B 🔽)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 550f0a3:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (441ba5f) 100.00% compared to head (550f0a3) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47227   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          732       732           
  Lines        12566     12566           
  Branches      3298      3298           
=========================================
  Hits         12566     12566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 9473ebf into master Jan 30, 2024
114 checks passed
@MadCcc MadCcc deleted the fix/menu-submenu-hover branch January 30, 2024 09:55
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu 在 inlineCollapsed/mode="vertical" 时,触发二级菜单的交互区域貌似有问题?
2 participants