Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rm Tag useless style #47504

Merged
merged 1 commit into from Feb 21, 2024
Merged

fix: rm Tag useless style #47504

merged 1 commit into from Feb 21, 2024

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Feb 20, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

image

📝 Changelog

Language Changelog
🇺🇸 English ⚠️ rm Tag useless style
🇨🇳 Chinese ⚠️ 删除 Tag 组件多余的 margin

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Feb 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Feb 20, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Feb 20, 2024

Visual Regression Build for PR #47504 Failed ❌

Potential causes:

  • upstream workflow status: failure upstream job link
  • download report artifact status: failure
  • report upload status: skipped

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 333.73 KB (-149 B 🔽)
./dist/antd-with-locales.min.js 379.63 KB (+11 B 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf51b5f) 100.00% compared to head (b1e6e48) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #47504   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          734       734           
  Lines        12617     12617           
  Branches      3307      3307           
=========================================
  Hits         12617     12617           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc
Copy link
Member

MadCcc commented Feb 20, 2024

changelog 标注一下重要变化

@li-jia-nan
Copy link
Member Author

changelog 标注一下重要变化

image

这样可以不?

@MadCcc
Copy link
Member

MadCcc commented Feb 20, 2024

image

这样可以不?

参考一下以往的 changelog,前面不用带 type。
前面可以加上 ⚠️,最终写 changelog 时单独分一栏

@MadCcc MadCcc merged commit 2bb7e9e into feature Feb 21, 2024
118 of 119 checks passed
@MadCcc MadCcc deleted the tag-fix branch February 21, 2024 01:58
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@powerfulyang
Copy link

不是这个 commit 真的是莫名其妙?你有考虑只有一个 tag 单独用的情况,原本显示正常现在这个 commit 造成 breaking change 了!希望 revert 这个修改。

@powerfulyang
Copy link

@arvinxx
Copy link
Contributor

arvinxx commented Mar 6, 2024

@powerfulyang 就是刻意改的,原本的代码实现在样式上是有问题的。

组合场景下包一个 <Flex gap={'small'}>{ ... } </Flex> 更是符合常规操作,反而是现在这种单个使用的情况下对样式的影响很大。

@MadCcc
Copy link
Member

MadCcc commented Mar 6, 2024

@powerfulyang 很抱歉对你的应用产生了不良影响,但这次改动在我们治理的一环,我们会调整 changelog 的优先级。

@zombieJ
Copy link
Member

zombieJ commented Mar 6, 2024

这个还是要兜一下的,你如果发现后面接的是个 tag 你就保留 margin。不是的话再去掉。否则这个挺蛋疼

@powerfulyang
Copy link

主要问题现在这是一个 breaking change 了。已经当 feature 用了,结果你删了,我觉得没必要。

@MadCcc
Copy link
Member

MadCcc commented Mar 6, 2024

主要问题现在这是一个 breaking change 了。已经当 feature 用了,结果你删了,我觉得没必要。

我们会加上兼容逻辑,针对连续的 Tag 会自动加上 margin

@powerfulyang
Copy link

@powerfulyang 就是刻意改的,原本的代码实现在样式上是有问题的。

组合场景下包一个 <Flex gap={'small'}>{ ... } </Flex> 更是符合常规操作,反而是现在这种单个使用的情况下对样式的影响很大。

请弄清楚是你们现在的改动对已存在的项目改动很大,是我们 5.15.0 版本之前的用户全部受影响(升级之后自己手动再把 margin 加上),就因为你们觉得更合逻辑。

@powerfulyang
Copy link

特别是那些不锁版本 不提交 lock 文件的用户,只会跟我一样骂娘。

@yoyo837
Copy link
Contributor

yoyo837 commented Mar 6, 2024

特别是那些不锁版本 不提交 lock 文件的用户,只会跟我一样骂娘。

胆儿忒大了 /狗头

@zombieJ
Copy link
Member

zombieJ commented Mar 6, 2024

请弄清楚是你们现在的改动对已存在的项目改动很大,是我们 5.15.0 版本之前的用户全部受影响(升级之后自己手动再把 margin 加上),就因为你们觉得更合逻辑。

嗯,不合理。得 patch 兜一下。

@powerfulyang
Copy link

特别是那些不锁版本 不提交 lock 文件的用户,只会跟我一样骂娘。

胆儿忒大了 /狗头

🐶 你猜猜我为什么过来

@MadCcc MadCcc mentioned this pull request Mar 6, 2024
20 tasks
tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants