New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rm Tag useless style #47504
fix: rm Tag useless style #47504
Conversation
Run & review this pull request in StackBlitz Codeflow. |
Visual Regression Build for PR #47504 Failed ❌Potential causes:
|
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #47504 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 734 734
Lines 12617 12617
Branches 3307 3307
=========================================
Hits 12617 12617 ☔ View full report in Codecov by Sentry. |
changelog 标注一下重要变化 |
不是这个 commit 真的是莫名其妙?你有考虑只有一个 tag 单独用的情况,原本显示正常现在这个 commit 造成 breaking change 了!希望 revert 这个修改。 |
@powerfulyang 就是刻意改的,原本的代码实现在样式上是有问题的。 组合场景下包一个 |
@powerfulyang 很抱歉对你的应用产生了不良影响,但这次改动在我们治理的一环,我们会调整 changelog 的优先级。 |
这个还是要兜一下的,你如果发现后面接的是个 tag 你就保留 margin。不是的话再去掉。否则这个挺蛋疼 |
主要问题现在这是一个 breaking change 了。已经当 feature 用了,结果你删了,我觉得没必要。 |
我们会加上兼容逻辑,针对连续的 Tag 会自动加上 margin |
请弄清楚是你们现在的改动对已存在的项目改动很大,是我们 5.15.0 版本之前的用户全部受影响(升级之后自己手动再把 margin 加上),就因为你们觉得更合逻辑。 |
特别是那些不锁版本 不提交 lock 文件的用户,只会跟我一样骂娘。 |
胆儿忒大了 /狗头 |
嗯,不合理。得 patch 兜一下。 |
🐶 你猜猜我为什么过来 |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge