Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: translate all to indonesian #48287

Merged
merged 6 commits into from Apr 16, 2024
Merged

Conversation

edikurniawan-dev
Copy link
Contributor

@edikurniawan-dev edikurniawan-dev commented Apr 5, 2024

I have transalate all to Indonesian

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

I have transalate all to Indonesian

Signed-off-by: Edi Kurniawan <edikurniawan.dev@gmail.com>
Copy link

stackblitz bot commented Apr 5, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 5, 2024

👁 Visual Regression Report for PR #48287 Passed ✅

🎯 Target branch: master (33ae55f)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Apr 5, 2024

  • 🚨 Please fill changelog in the PR

    • Write with a developer-oriented perspective and narrative method, without describing the details of the repair
    • Describing the problem and the impact on the developer
    • describing the user-first site problem, not your solution
    • Refer: https://ant.design/changelog#501
  • 🚨 请填写 PR 中的 changelog

    • 请用面向开发者的角度叙述方式撰写,不描述修复细节
    • 描述问题和对开发者的影响
    • 描述用户第一现场的问题,而非你的解决方式
    • 参考:https://ant.design/changelog-cn#501

Copy link
Contributor

github-actions bot commented Apr 5, 2024

Preview is ready

Copy link

codesandbox-ci bot commented Apr 5, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@li-jia-nan
Copy link
Member

You need to update the snapshot:

npm run test:update components/locale

@afc163
Copy link
Member

afc163 commented Apr 5, 2024

feature branch~

@yoyo837
Copy link
Contributor

yoyo837 commented Apr 5, 2024

Personally, I think it’s okay to merge into master. It's for #23369.

@afc163
Copy link
Member

afc163 commented Apr 9, 2024

ping @edikurniawan-dev

Signed-off-by: Edi Kurniawan <edikurniawan.dev@gmail.com>
@afc163
Copy link
Member

afc163 commented Apr 12, 2024

#48287 (comment)

@edikurniawan-dev
Copy link
Contributor Author

edikurniawan-dev commented Apr 12, 2024

sorry, where to update it? package.json?

@afc163
Copy link
Member

afc163 commented Apr 12, 2024

Test failed in https://github.com/ant-design/ant-design/actions/runs/8656389920/job/23737124629?pr=48287 , run npm run test:update components/locale in your machine, check the diff and commit it.

@afc163
Copy link
Member

afc163 commented Apr 16, 2024

ping @edikurniawan-dev

@edikurniawan-dev
Copy link
Contributor Author

i got this error when run npm run test:update components/locale
image

@afc163
Copy link
Member

afc163 commented Apr 16, 2024

@edikurniawan-dev

Try npm test -- -u components/locale

components/locale/id_ID.ts Outdated Show resolved Hide resolved
Signed-off-by: Edi Kurniawan <edikurniawan.dev@gmail.com>
@edikurniawan-dev
Copy link
Contributor Author

I have already run test in my local machine, and all passed

image

@afc163
Copy link
Member

afc163 commented Apr 16, 2024

Please commit and push the snapshot changes on your machine.

@li-jia-nan
Copy link
Member

In the components/locale/__tests__/__snapshots__/index.test.tsx.snap:

image

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fa6f113) to head (ed1b7db).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48287   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          744       744           
  Lines        12880     12881    +1     
  Branches      3367      3367           
=========================================
+ Hits         12880     12881    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit acbc46d into ant-design:master Apr 16, 2024
61 checks passed
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants