Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typography dynamic of copyable & eidtable #48350

Merged
merged 3 commits into from Apr 9, 2024
Merged

fix: Typography dynamic of copyable & eidtable #48350

merged 3 commits into from Apr 9, 2024

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 9, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #48344

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Typography dynamic set copyable or editable will not show the operation button.
🇨🇳 Chinese 修复 Typography 动态配置 copyableeditable 时不会显示操作按钮的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 9, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Apr 9, 2024

👁 Visual Regression Report for PR #48350 Failed ❌

🎯 Target branch: master (727aa2d)
📖 View Full Report ↗︎

Image name Expected Actual Diff
steps-label-placement.compact.css-var.png master: 727aa2d03007944e89fcb8eb9075aac8dccc5f4b current: pr-48350 diff
steps-label-placement.dark.css-var.png master: 727aa2d03007944e89fcb8eb9075aac8dccc5f4b current: pr-48350 diff
steps-label-placement.default.css-var.png master: 727aa2d03007944e89fcb8eb9075aac8dccc5f4b current: pr-48350 diff
steps-progress-debug.dark.css-var.png master: 727aa2d03007944e89fcb8eb9075aac8dccc5f4b current: pr-48350 diff
steps-progress.compact.css-var.png master: 727aa2d03007944e89fcb8eb9075aac8dccc5f4b current: pr-48350 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Apr 9, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 336.44 KB (-4 B 🔽)
./dist/antd-with-locales.min.js 383.6 KB (+121 B 🔺)

Copy link

codesandbox-ci bot commented Apr 9, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (727aa2d) to head (fc0fb12).

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48350   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          744       744           
  Lines        12861     12861           
  Branches      3365      3365           
=========================================
  Hits         12861     12861           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit 44cd534 into master Apr 9, 2024
108 of 109 checks passed
@zombieJ zombieJ deleted the fix-edit branch April 9, 2024 04:01
@crazyair
Copy link
Member

不会显示操作按钮?

@PeachScript PeachScript mentioned this pull request Apr 13, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typography with dynamic Editable not rendering edit icon correctly
3 participants