fix: fix the flex gap problem #48522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
👁 Visual Regression Report for PR #48522 Passed ✅
🎊 Congrats! No visual-regression diff found. 
|
|
|
|
Smooth again. 🥳 Upload.-.Ant.Design.18.-.-.Microsoft.Edge.2024-04-18.00-49-18.mp4 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #48522 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 744 744
Lines 12883 12883
Branches 3369 3369
=========================================
Hits 12883 12883 ☔ View full report in Codecov by Sentry. |
afc163
approved these changes
Apr 18, 2024
MadCcc
reviewed
Apr 18, 2024
| height: 0, | ||
| padding: 0, | ||
| opacity: 0, | ||
| margin: `calc(${token.marginXS} / -2)`, |
There was a problem hiding this comment.
token.calc(token.marginXS).div(-2).equal()
There was a problem hiding this comment.
So should I make a new PR for this?
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related issue link
#48505
💡 Background and solution
Related to PR #48091.
Css attribute
gapinflexitem still takes effect when the DOMelementsize is set to 0. Setting a negative margin can solve this problem.📝 Changelog
upload组件图片卡的动画效果☑️ Self-Check before Merge