Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump netty version to 4.1.75.Final #3091

Closed
wants to merge 1 commit into from
Closed

Bump netty version to 4.1.75.Final #3091

wants to merge 1 commit into from

Conversation

shoothzj
Copy link
Member

Motivation

Changelog: https://netty.io/news/2022/03/10/4-1-75-Final.html

Netty 4.1.75 has netty/netty#12103 feature that #2989 needs

Modifications

  • Upgrade Netty from 4.1.74.Final to 4.1.75.Final
  • Netty 4.1.75.Final depends on netty-tc-native 2.0.50, also updates

@shoothzj
Copy link
Member Author

rerun failure checks

eolivelli
eolivelli approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ! especially the Netty patch!

@dlg99 dlg99 closed this Mar 11, 2022
@dlg99 dlg99 reopened this Mar 11, 2022
dlg99
dlg99 requested changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@dlg99 dlg99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shoothzj Integration Tests hang/time out consistently, always on the same task :tests:integration:cluster:test. This does not happen on other PRs. Can you please take a look?

@shoothzj
Copy link
Member Author

@dlg99 It's caused by grpc/grpc-java#8981. I will follow up on this

@shoothzj shoothzj mentioned this pull request Mar 12, 2022
Merged
@shoothzj
Copy link
Member Author

use #3163 instead

@shoothzj shoothzj closed this Mar 31, 2022
@shoothzj shoothzj deleted the netty-75 branch March 31, 2022 06:54
@shoothzj shoothzj mentioned this pull request Mar 31, 2022
Merged
@shoothzj shoothzj mentioned this pull request May 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlg99 dlg99 dlg99 requested changes

@eolivelli eolivelli eolivelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shoothzj @dlg99 @eolivelli