feat: Deprecated onRequestPermissionResult in favour for onRequestPermissionsResult for consistency #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…missionsResult for consistency
erisu
approved these changes
Aug 11, 2020
wedgberto
pushed a commit
to wedgberto/cordova-android
that referenced
this pull request
May 17, 2022
…missionsResult for consistency (apache#1047)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
Closes #592
Description
Deprecates
onRequestPermissionResultforonRequestPermissionsResultfor consistency with the Android APIThis change is not breaking, but will signal a breaking change some time in the future.
Testing
Ran
npm testAlso did a live manual test with the geolocation plugin, both with it using the deprecated method and the new method.
Checklist
(platform)if this change only applies to one platform (e.g.(android))