Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Deprecated onRequestPermissionResult in favour for onRequestPermissionsResult for consistency #1047

Merged
merged 1 commit into from
Apr 13, 2021
Merged

feat: Deprecated onRequestPermissionResult in favour for onRequestPermissionsResult for consistency #1047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 15 additions & 0 deletions framework/src/org/apache/cordova/CordovaPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,9 +414,24 @@ public boolean hasPermisssion() {
* @param requestCode
* @param permissions
* @param grantResults
*
* @deprecated Use {@link #onRequestPermissionsResult} instead.
*/
@Deprecated
public void onRequestPermissionResult(int requestCode, String[] permissions,
int[] grantResults) throws JSONException {

}

/**
* Called by the system when the user grants permissions
*
* @param requestCode
* @param permissions
* @param grantResults
*/
public void onRequestPermissionsResult(int requestCode, String[] permissions,
int[] grantResults) throws JSONException {

}
}
2 changes: 2 additions & 0 deletions framework/src/org/apache/cordova/PermissionHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,9 @@ private static void deliverPermissionResult(CordovaPlugin plugin, int requestCod
Arrays.fill(requestResults, PackageManager.PERMISSION_GRANTED);

try {
// This one is deprecated - see https://github.com/apache/cordova-android/issues/592
plugin.onRequestPermissionResult(requestCode, permissions, requestResults);
plugin.onRequestPermissionsResult(requestCode, permissions, requestResults);
} catch (JSONException e) {
LOG.e(LOG_TAG, "JSONException when delivering permissions results", e);
}
Expand Down