refactor(env/java): improve tests and implementation #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1246 +/- ##
==========================================
- Coverage 72.00% 71.90% -0.11%
==========================================
Files 21 21
Lines 1697 1694 -3
==========================================
- Hits 1222 1218 -4
- Misses 475 476 +1
Continue to review full report at Codecov.
|
breautek
approved these changes
Jun 23, 2021
raphinesse
changed the title
sakibguy
added a commit
to sakibguy/cordova-android
that referenced
this pull request
Jun 24, 2021
refactor(env/java): improve tests and implementation (apache#1246)
wedgberto
pushed a commit
to wedgberto/cordova-android
that referenced
this pull request
May 17, 2022
This basically fixes up the changes from apache#1220. * test(env/java): replace test that duplicates implementation * test(env/java): stub _ensure to focus on unit under test * test(env/java): add test for invalid output * refactor(env/java): keep try block small * refactor(env/java): shorten excessive comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR basically fixes up the changes from #1220. I was too busy to point out the problems before it was merged.
Description
Testing
The automated test suite passes