Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(env/java): improve tests and implementation #1246

Merged
merged 5 commits into from
Jun 23, 2021
Merged

refactor(env/java): improve tests and implementation #1246

merged 5 commits into from
Jun 23, 2021

Commits on Jun 23, 2021

  1. test(env/java): replace test that duplicates implementation

    @raphinesse
    raphinesse committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    2d0ee3a View commit details
    Browse the repository at this point in the history

  2. test(env/java): stub _ensure to focus on unit under test

    @raphinesse
    raphinesse committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    833b0b8 View commit details
    Browse the repository at this point in the history

  3. test(env/java): add test for invalid output

    @raphinesse
    raphinesse committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    d35d11b View commit details
    Browse the repository at this point in the history

  4. refactor(env/java): keep try block small

    @raphinesse
    raphinesse committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    9f1f29f View commit details
    Browse the repository at this point in the history

  5. refactor(env/java): shorten excessive comment

    @raphinesse
    raphinesse committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    5effa2d View commit details
    Browse the repository at this point in the history