refactor(run)!: cleanup run method #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1266 +/- ##
==========================================
- Coverage 71.55% 71.48% -0.07%
==========================================
Files 21 21
Lines 1649 1645 -4
==========================================
- Hits 1180 1176 -4
Misses 469 469
Continue to review full report at Codecov.
|
`parseBuildOptions` only sets `arch` if something truthy is passed for parameter `resolvedTarget` to which we pass `null`.
sakibguy
added a commit
to sakibguy/cordova-android
that referenced
this pull request
Jul 13, 2021
refactor(run)!: cleanup run method (apache#1266)
wedgberto
pushed a commit
to wedgberto/cordova-android
that referenced
this pull request
May 17, 2022
* refactor(run)!: get rid of emit-and-throw & throw-literal antipatterns * refactor(run)!: convert run method to async/await * refactor(run): require build module in advance * refactor(run): minor cleanup * refactor(run): drop always-undefined option arch `parseBuildOptions` only sets `arch` if something truthy is passed for parameter `resolvedTarget` to which we pass `null`. * refactor(run): destructure buildOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Refactoring that improves code quality of
run.runand prepares the stage for other changes.Description
See commit messages. Slightest change in behavior during errors due to the first two commits.
Testing
Automated tests still pass