Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(run)!: cleanup run method #1266

Merged
merged 6 commits into from
Jul 11, 2021
Merged

refactor(run)!: cleanup run method #1266

merged 6 commits into from
Jul 11, 2021

Commits on Jul 10, 2021

  1. refactor(run)!: get rid of emit-and-throw & throw-literal antipatterns

    @raphinesse
    raphinesse committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    f7aa870 View commit details
    Browse the repository at this point in the history

  2. refactor(run)!: convert run method to async/await

    @raphinesse
    raphinesse committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    fb85b2b View commit details
    Browse the repository at this point in the history

  3. refactor(run): require build module in advance

    @raphinesse
    raphinesse committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    8281df8 View commit details
    Browse the repository at this point in the history

  4. refactor(run): minor cleanup

    @raphinesse
    raphinesse committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    f0dbc64 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2021

  1. refactor(run): drop always-undefined option arch 

    `parseBuildOptions` only sets `arch` if something truthy is passed for
parameter `resolvedTarget` to which we pass `null`.
    @raphinesse
    raphinesse committed Jul 11, 2021
    Configuration menu
    Copy the full SHA
    e451c66 View commit details
    Browse the repository at this point in the history

  2. refactor(run): destructure buildOptions

    @raphinesse
    raphinesse committed Jul 11, 2021
    Configuration menu
    Copy the full SHA
    a98a0ce View commit details
    Browse the repository at this point in the history