Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: delete old ANT & Eclipse files #1272

Merged
merged 1 commit into from Jul 14, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Jul 13, 2021

Motivation, Context & Description

Remove old ANT/Eclipse related files.

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu force-pushed the cleanup/remove-ant-eclipse branch from 91f6fc4 to 17ce6f0 Compare July 13, 2021 10:18
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2021

Codecov Report

Merging #1272 (17ce6f0) into master (68a302e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1272   +/-   ##
=======================================
  Coverage   73.26%   73.26%           
=======================================
  Files          21       21           
  Lines        1646     1646           
=======================================
  Hits         1206     1206           
  Misses        440      440           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68a302e...17ce6f0. Read the comment docs.

Copy link
Contributor

@raphinesse raphinesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably should also remove the VERSION file. Seems it is only referenced from build.xml

Other than that: would be great to get rid of these seemingly long obsolete files.

@erisu
Copy link
Member Author

erisu commented Jul 13, 2021

I will create a separate PR for removing the VERSION file.

I think that the file was not from ANT nor Eclipse. I think it was something we created to easily manage the cordova-android version in one location and use it in places like ANT. I think it was apart of the pre-npm registry era.

Even through after this PR is merged, there should be no references to this file. I just want to make sure we can easily revert the VERSION drop if there was something unexpected that was not in our radar.

As for ANT & Eclipse, these are outdated tools that isnt genrally used or prefered for Android development/release anymore.

@erisu erisu merged commit f15fec8 into apache:master Jul 14, 2021
@erisu erisu deleted the cleanup/remove-ant-eclipse branch July 14, 2021 02:38
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants