Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup!: remove deprecated settings & add todo comments #1274

Merged
merged 4 commits into from Jul 14, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Jul 14, 2021

Motivation, Context & Description

Added Todo Comment setSaveFormData

Remove this setting once Cordova drops support for API Level 26.

This method was deprecated in API level 26.
In Android O and afterwards, this function does not have any effect, the form data will be saved to platform's autofill service if applicable.

Remove setSavePassword

This method was deprecated in API level 18.
Saving passwords in WebView will not be supported in future versions.

Remove setDatabasePath

This method was deprecated in API level 19.
Database paths are managed by the implementation and calling this method will have no effect.

Added Todo Comment: setGeolocationDatabasePath

Remove this setting once Cordova drops support for API Level 24.

This method was deprecated in API level 24.
Geolocation database are managed by the implementation and calling this method will have no effect.

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2021

Codecov Report

Merging #1274 (3135bf1) into master (3e870e3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1274   +/-   ##
=======================================
  Coverage   73.26%   73.26%           
=======================================
  Files          21       21           
  Lines        1646     1646           
=======================================
  Hits         1206     1206           
  Misses        440      440           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e870e3...3135bf1. Read the comment docs.

@erisu erisu changed the title Cleanup/remove deprecated settings cleanup!: remove deprecated settings & add todo comments Jul 14, 2021
@NiklasMerz NiklasMerz added this to the 10.0.0 milestone Jul 14, 2021
@erisu erisu merged commit adc380c into apache:master Jul 14, 2021
@erisu erisu deleted the cleanup/remove-deprecated-settings branch July 14, 2021 06:37
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
* chore: add todo task for setSaveFormData
* cleanup!: remove deprecated setSavePassword
* cleanup!: remove deprecated setDatabasePath
* chore: add todo task for setGeolocationDatabasePath
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants