Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup!: remove deprecated settings & add todo comments #1274

Merged
merged 4 commits into from
Jul 14, 2021
Merged

cleanup!: remove deprecated settings & add todo comments #1274

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5698206
chore: add todo task for setSaveFormData
erisu Jul 14, 2021
aaf425b
cleanup!: remove deprecated setSavePassword
erisu Jul 14, 2021
6367ec1
cleanup!: remove deprecated setDatabasePath
erisu Jul 14, 2021
3135bf1
chore: add todo task for setGeolocationDatabasePath
erisu Jul 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 3 additions & 4 deletions framework/src/org/apache/cordova/engine/SystemWebViewEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,9 @@ private void initWebViewSettings() {
String manufacturer = android.os.Build.MANUFACTURER;
LOG.d(TAG, "CordovaWebView is running on device made by: " + manufacturer);

//We don't save any form data in the application
// We don't save any form data in the application
// @todo remove when Cordova drop API level 26 support
settings.setSaveFormData(false);
settings.setSavePassword(false);

if (preferences.getBoolean("AndroidInsecureFileModeEnabled", false)) {
//These settings are deprecated and loading content via file:// URLs is generally discouraged,
Expand All @@ -173,15 +173,14 @@ private void initWebViewSettings() {
// We keep this disabled because we use or shim to get around DOM_EXCEPTION_ERROR_16
String databasePath = webView.getContext().getApplicationContext().getDir("database", Context.MODE_PRIVATE).getPath();
settings.setDatabaseEnabled(true);
settings.setDatabasePath(databasePath);


//Determine whether we're in debug or release mode, and turn on Debugging!
ApplicationInfo appInfo = webView.getContext().getApplicationContext().getApplicationInfo();
if ((appInfo.flags & ApplicationInfo.FLAG_DEBUGGABLE) != 0) {
enableRemoteDebugging();
}

// @todo remove when Cordova drop API level 24 support
settings.setGeolocationDatabasePath(databasePath);

// Enable DOM storage
Expand Down