fix: correctly flag API dependency on AppCompat for Maven #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when cordova-android is published to Maven, it lists no dependencies. However, `CordovaActivity` extends `AppCompatActivity` which requires that the AndroidX AppCompat library be available. Marking this as an API dependency (rather than an implementation/compile dependency) should cause the AndroidX AppCompat library to be installed when the cordova-android framework is added to the build.gradle of an existing Android application.
This allows the Maven publish to pick up information from the android library component and include things like dependencies in the pom.xml file.
Codecov Report
@@ Coverage Diff @@
## master #1505 +/- ##
=======================================
Coverage 72.13% 72.13%
=======================================
Files 21 21
Lines 1751 1751
=======================================
Hits 1263 1263
Misses 488 488 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
erisu
approved these changes
Oct 8, 2022
erisu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
Currently when cordova-android is published to Maven, it lists no dependencies. However,
CordovaActivityextendsAppCompatActivitywhich requires that the AndroidX AppCompat library be available.Description
Marking AndroidX AppCompat as an API dependency (rather than an implementation/compile dependency) should cause the AndroidX AppCompat library to be installed when the cordova-android framework is added to the build.gradle of an existing Android application.
Testing
Tested publishing to my local Maven repository, and confirmed that dependencies are correctly captured in the pom.xml.