Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly flag API dependency on AppCompat for Maven #1505

Merged
merged 2 commits into from
Oct 15, 2022
Merged

fix: correctly flag API dependency on AppCompat for Maven #1505

merged 2 commits into from
Oct 15, 2022

Commits on Oct 8, 2022

  1. Correctly flag API dependency on AppCompat for Maven 

    Currently when cordova-android is published to Maven, it lists no
dependencies. However, `CordovaActivity` extends `AppCompatActivity`
which requires that the AndroidX AppCompat library be available.

Marking this as an API dependency (rather than an implementation/compile
dependency) should cause the AndroidX AppCompat library to be installed
when the cordova-android framework is added to the build.gradle of an
existing Android application.
    @dpogue
    dpogue committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    38e95ee View commit details
    Browse the repository at this point in the history

  2. Publish to Maven with proper metadata 

    This allows the Maven publish to pick up information from the android
library component and include things like dependencies in the pom.xml
file.
    @dpogue
    dpogue committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    877c76d View commit details
    Browse the repository at this point in the history