Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep!: April 2024 update #270

Merged
merged 10 commits into from
Apr 10, 2024
Merged

dep!: April 2024 update #270

merged 10 commits into from
Apr 10, 2024

Conversation

erisu
Copy link
Member

@erisu erisu commented Apr 8, 2024

Platforms affected

n/a

Motivation and Context

Update CI & NPM dependencies & package-lock.json

Description

NPM dependencies:

  • globby@^11.1.0
  • grunt@^1.6.1
  • grunt-contrib-clean@^2.0.1
  • jasmine-core@^5.1.2
  • karma@^6.4.3
  • karma-chrome-launcher@^3.2.0
  • karma-coverage@^2.2.1
  • puppeteer@^22.6.3
  • @cordova/eslint-config@^5.1.0

NPM package chores:

  • rebuilt package-lock.json
  • fix node engine in package-lock.json

CI dependencies:

  • actions/checkout@v4
  • actions/setup-node@v4
  • codecov/codecov-action@v4 w/ token entry

This PR will not cover upgrading the following packages and will be handled in a separate PR:

"cordova-android": "^9.1.0",
"cordova-ios": "^5.1.1",

The above packages will need to be fetched with git and not npm. The npm packages, even if pointing to the git repo, does not come with the files that are needed for testing.

Testing

  • npm t
  • npm run build

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu changed the title dep: April 2024 update dep!: April 2024 update Apr 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.62%. Comparing base (c7d3dc0) to head (89f15ff).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   83.62%   83.62%           
=======================================
  Files          14       14           
  Lines         519      519           
=======================================
  Hits          434      434           
  Misses         85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erisu erisu marked this pull request as ready for review April 10, 2024 02:51
@erisu erisu merged commit fefb3e7 into apache:master Apr 10, 2024
9 checks passed
@erisu erisu deleted the dep/april-2024-update branch April 10, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants