Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-14728: Don't run 'spotlessScalaCheck' in CI #13263

Merged
merged 1 commit into from Feb 23, 2023

Conversation

dejan2609
Copy link
Contributor

@dejan2609 dejan2609 commented Feb 16, 2023

Blocks #13205.

Rationale:

  • build works fine in trunk with Gradle 7.6 and spotless gradle plugin 6.13.0 for all currently used JDK versions (that is: JDK 8 / JDK 11 / JDK 17)
  • however, recent spotless gradle plugin versions (6.14.+) support only JDK 11+ versions: https://github.com/diffplug/spotless/blob/main/plugin-gradle/CHANGES.md#6140---2023-01-26
  • given a fact that Kafka still needs to support JDK 8 builds (until Kafka version 4.0) it is reasonable to simply remove spotless checks out of Jenkinsfile (and re-introduce them when the time comes).

For even more details see GitHub discussion here: #13205 (comment)

@dejan2609
Copy link
Contributor Author

Only handfull of tests failed (those errors are obviosly unrelated to this small change).

FYI @ijuma

@ijuma
Copy link
Contributor

ijuma commented Feb 23, 2023

@mjsax @vvcephei I'm going to merge this PR. If we find a way to support this tool without requiring Java 11, we can re-enable before Apache Kafka 4.0. If not, we can re-enable once we drop support for Java 8. @dejan2609 can you please file a JIRA for re-enabling this with target version 4.0 and set it as a blocker?

Copy link
Contributor

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@ijuma ijuma changed the title KAFKA-14728: Gradle task 'spotlessScalaCheck' is moved out of Jenkinsfile KAFKA-14728: Don't run 'spotlessScalaCheck' in CI Feb 23, 2023
@ijuma ijuma merged commit 97efdc6 into apache:trunk Feb 23, 2023
@guozhangwang
Copy link
Contributor

Thanks @ijuma for the heads up, that makes sense.

@dejan2609
Copy link
Contributor Author

@ijuma JIRA ticket created here: https://issues.apache.org/jira/browse/KAFKA-14749

@ijuma
Copy link
Contributor

ijuma commented Feb 27, 2023

@guozhangwang Note that we found a way to re-enable this when running with Java 11 or newer, see #13311.

@dejan2609 dejan2609 deleted the removeSpotlessScalaCheck branch March 5, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants