Upgrade Netty to 4.1.76.Final, Netty Tcnative, grpc and protobuf #15212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested review from
merlimat,
Jason918,
eolivelli,
codelipenghui,
shoothzj and
dave2wave
RobertIndie
approved these changes
Apr 19, 2022
RobertIndie
added
the
area/dependency
|
I don't know if we can easily update version, I meeted a grpc problem grpc/grpc-java#9004 when I try to upgrage netty version in bookkeeper apache/bookkeeper#3163 |
Fixes apache#14015 - release notes https://netty.io/news/2022/04/12/4-1-76-Final.html - contains fix for netty/netty#11695
lhotari
force-pushed
the
lh-netty-4.1.76.Final
branch
from
7053221
to
de79918
Compare
Thanks for the heads up. I guess I'll need to do a similar upgrade for Pulsar dependencies. btw. It would be good to get that resolved in Bookkeeper 4.15.0 release. |
lhotari
changed the title
Demogorgon314
approved these changes
Apr 19, 2022
lhotari
force-pushed
the
lh-netty-4.1.76.Final
branch
from
f92ab73
to
d690028
Compare
codelipenghui
approved these changes
Apr 19, 2022
- grpc < 1.45.1 is not compatible with Netty > 4.1.74.Final - grpc/grpc-java#9004
lhotari
force-pushed
the
lh-netty-4.1.76.Final
branch
from
d690028
to
c282f1f
Compare
gaoran10
approved these changes
Apr 19, 2022
4 tasks
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
…che#15212) * Upgrade Netty to 4.1.76.Final and Netty Tcnative to 2.0.51.Final Fixes apache#14015 - release notes https://netty.io/news/2022/04/12/4-1-76-Final.html - contains fix for netty/netty#11695 * Upgrade grpc to 1.45.1 and protobuf to 3.19.2 - grpc < 1.45.1 is not compatible with Netty > 4.1.74.Final - grpc/grpc-java#9004
lhotari
added a commit
to datastax/pulsar
that referenced
this pull request
Apr 20, 2022
…che#15212) * Upgrade Netty to 4.1.76.Final and Netty Tcnative to 2.0.51.Final Fixes apache#14015 - release notes https://netty.io/news/2022/04/12/4-1-76-Final.html - contains fix for netty/netty#11695 * Upgrade grpc to 1.45.1 and protobuf to 3.19.2 - grpc < 1.45.1 is not compatible with Netty > 4.1.74.Final - grpc/grpc-java#9004 (cherry picked from commit 332a3c7)
gaoran10
pushed a commit
that referenced
this pull request
Apr 21, 2022
) * Upgrade Netty to 4.1.76.Final and Netty Tcnative to 2.0.51.Final Fixes #14015 - release notes https://netty.io/news/2022/04/12/4-1-76-Final.html - contains fix for netty/netty#11695 * Upgrade grpc to 1.45.1 and protobuf to 3.19.2 - grpc < 1.45.1 is not compatible with Netty > 4.1.74.Final - grpc/grpc-java#9004 (cherry picked from commit 332a3c7)
gaoran10
pushed a commit
that referenced
this pull request
Apr 21, 2022
) * Upgrade Netty to 4.1.76.Final and Netty Tcnative to 2.0.51.Final Fixes #14015 - release notes https://netty.io/news/2022/04/12/4-1-76-Final.html - contains fix for netty/netty#11695 * Upgrade grpc to 1.45.1 and protobuf to 3.19.2 - grpc < 1.45.1 is not compatible with Netty > 4.1.74.Final - grpc/grpc-java#9004 (cherry picked from commit 332a3c7)
lhotari
added a commit
to datastax/pulsar
that referenced
this pull request
Apr 22, 2022
…che#15212) * Upgrade Netty to 4.1.76.Final and Netty Tcnative to 2.0.51.Final Fixes apache#14015 - release notes https://netty.io/news/2022/04/12/4-1-76-Final.html - contains fix for netty/netty#11695 * Upgrade grpc to 1.45.1 and protobuf to 3.19.2 - grpc < 1.45.1 is not compatible with Netty > 4.1.74.Final - grpc/grpc-java#9004 (cherry picked from commit 332a3c7)
lhotari
added a commit
to datastax/pulsar
that referenced
this pull request
Apr 22, 2022
…che#15212) * Upgrade Netty to 4.1.76.Final and Netty Tcnative to 2.0.51.Final Fixes apache#14015 - release notes https://netty.io/news/2022/04/12/4-1-76-Final.html - contains fix for netty/netty#11695 * Upgrade grpc to 1.45.1 and protobuf to 3.19.2 - grpc < 1.45.1 is not compatible with Netty > 4.1.74.Final - grpc/grpc-java#9004 (cherry picked from commit 332a3c7)
codelipenghui
pushed a commit
that referenced
this pull request
Apr 28, 2022
) * Upgrade Netty to 4.1.76.Final and Netty Tcnative to 2.0.51.Final Fixes #14015 - release notes https://netty.io/news/2022/04/12/4-1-76-Final.html - contains fix for netty/netty#11695 * Upgrade grpc to 1.45.1 and protobuf to 3.19.2 - grpc < 1.45.1 is not compatible with Netty > 4.1.74.Final - grpc/grpc-java#9004 (cherry picked from commit 332a3c7)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 28, 2022
…che#15212) * Upgrade Netty to 4.1.76.Final and Netty Tcnative to 2.0.51.Final Fixes apache#14015 - release notes https://netty.io/news/2022/04/12/4-1-76-Final.html - contains fix for netty/netty#11695 * Upgrade grpc to 1.45.1 and protobuf to 3.19.2 - grpc < 1.45.1 is not compatible with Netty > 4.1.74.Final - grpc/grpc-java#9004 (cherry picked from commit 332a3c7)
Jason918
pushed a commit
to Jason918/pulsar
that referenced
this pull request
Aug 1, 2022
…che#15212) * Upgrade Netty to 4.1.76.Final and Netty Tcnative to 2.0.51.Final Fixes apache#14015 - release notes https://netty.io/news/2022/04/12/4-1-76-Final.html - contains fix for netty/netty#11695 * Upgrade grpc to 1.45.1 and protobuf to 3.19.2 - grpc < 1.45.1 is not compatible with Netty > 4.1.74.Final - grpc/grpc-java#9004 (cherry picked from commit 332a3c7)
2 tasks
|
Move |
Jason918
pushed a commit
to Jason918/pulsar
that referenced
this pull request
Aug 1, 2022
…che#15212) * Upgrade Netty to 4.1.76.Final and Netty Tcnative to 2.0.51.Final Fixes apache#14015 - release notes https://netty.io/news/2022/04/12/4-1-76-Final.html - contains fix for netty/netty#11695 * Upgrade grpc to 1.45.1 and protobuf to 3.19.2 - grpc < 1.45.1 is not compatible with Netty > 4.1.74.Final - grpc/grpc-java#9004 (cherry picked from commit 332a3c7)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14015
Motivation
Since the current version is 4.1.74.Final, the upgrade will also contain 4.1.75.Final changes,
A notable change that comes with Netty Tcnative 2.0.51.Final is the change that boringssl native libraries are packaged in separate jar file. That change seems to have been made in netty/netty-tcnative#696 in Netty Tcnative 2.0.49.Final .
grpc < 1.45.1 is not compatible with Netty > 4.1.74.Final: grpc/grpc-java#9004
Modifications
Upgrade Netty to 4.1.76.Final and Netty Tcnative to 2.0.51.Final
Upgrade grpc to 1.45.1
Upgrade protobuf to 3.19.2