deprecate useFragement returnPartialData option
#10764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d0b1fa5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
phryneas
force-pushed
the
pr/deprecate-useFragment-returnPartialData
branch
from
885a02e
to
98ec144
Compare
phryneas
requested review from
alessbell,
benjamn and
jerelmiller
and removed request for
alessbell
3 tasks
3 tasks
jerelmiller
approved these changes
Apr 14, 2023
Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #10760 and would address #10650.
It would mark the
returnPartialDataoption ofuseFragementas@deprecatedin v3.7. Once that has moved in and is merged into 3.8, I will add another PR that removes the option.This also adds test for the current default value of
true(which was documented asfalseuntil now, by inheriting from other options interfaces) and the behaviour ofthrowing an error in case of incomplete data withreturnPartialData: false- which was not intended, but would IMHO be too much of a change to be fixed within 3.7.Checklist: