Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 3.4.0 #7399

Merged
merged 454 commits into from Jul 28, 2021
Merged

Release 3.4.0 #7399

merged 454 commits into from Jul 28, 2021

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented Dec 1, 2020

Like the Release 3.3.0 PR, this PR will serve to collect significant new features, deprecation warnings, and minor breaking changes that we intend to release in @apollo/client@3.4.0.

If you want to test these changes, run

npm i @apollo/client@3.4.0-beta.n

in your application, where the n in -beta.n comes from the most recent commit message like

Bump @apollo/client npm version to 3.4.0-beta.n.

Until v3.4.0 is released, we can continue merging smaller changes into main and releasing them, without worrying about larger changes on the release-3.4 branch.

@benjamn benjamn added this to the Release 3.4 milestone Dec 1, 2020
@benjamn benjamn force-pushed the release-3.4 branch 2 times, most recently from de78a83 to 57a6b9e Compare December 4, 2020 20:35
@benjamn benjamn mentioned this pull request Jan 25, 2021
Closed
@benjamn benjamn mentioned this pull request Feb 3, 2021
Closed
@benjamn

This comment has been minimized.

Sign in to view
This was referenced Mar 11, 2021
Merged
Closed
@hwillson hwillson added this to In progress in Release 3.4 Mar 16, 2021
@abdonrd
Copy link
Contributor

abdonrd commented Mar 22, 2021 •
edited

@benjamn I get an error when update from v3.4.0-beta.14 to v3.4.0-beta.15:
Screenshot 2021-03-22 at 14 12 57

This file is: https://github.com/graphql/graphql-js/blob/v15.2.0/src/jsutils/instanceOf.js#L14
But that file hasn't changed since January 2020.

All works if I go back to v3.4.0-beta.14.

I'm using the @web/dev-server.

@abdonrd
Copy link
Contributor

abdonrd commented Mar 24, 2021

@benjamn I add the npm dependencies diff about #7399 (comment):

apollo-error

This downgrade makes the project work again.

@abdonrd abdonrd mentioned this pull request Mar 25, 2021
Closed
@benjamn
Copy link
Member Author

benjamn commented Mar 25, 2021

@abdonrd Thanks for the heads up! Just linking to my comment on your issue for others' benefit: #7895 (comment)

@benjamn benjamn mentioned this pull request Apr 27, 2021
Closed
@benjamn benjamn force-pushed the release-3.4 branch 2 times, most recently from f7caa87 to 4420c49 Compare April 29, 2021 18:49
@benjamn
Copy link
Member Author

benjamn commented May 11, 2021 •
edited

@StephenBarlow Looking at the client.watchQuery options, I noticed we only display the options that are not in the client.query options (below), even though WatchQueryOptions inherits from QueryOptions (and adds/redefines a few new options, like fetchPolicy). Is there anything we can do about that? Not urgent, just curious.

@StephenBarlow
Copy link
Contributor

@benjamn You mean in the autogenerated reference, yes? I fear I know very little about its internal workings, and it predates me. My guess would be that doing something about this would require an amount of work similar to either:

  • Moving Apollo Client off of autogenerated references entirely
  • Revamping the autogeneration process entirely

Both of which feel preferable to tacking features onto our existing solution, which as I understand it is creaky

@benjamn
Basic tests of client.refetchQueries API.
fd8a94c
@benjamn
Refetch updateCache-triggered queries if onQueryUpdated not provided.
e02f8a1
@benjamn
Add a few TODOs to client.refetchQueries test file.
967ade3
@benjamn
Make dirtying of removed EntityStore Layer fields more precise.
dfe9e68 
Previously, removing an optimistic EntityStore layer with
removeOptimistic would dirty all fields of any StoreObjects contained by
the removed layer, ignoring the possibility that some of those field
values might have been inherited as-is from the parent layer.

With this commit, we dirty only those fields whose values will be
observably changed by removing the layer, which requires comparing field
values between the layer-to-be-removed and its parent layer.
@benjamn
Test client.refetchQueries({ optimistic: true }).
bee43b0
@benjamn
Move refetchQueries-related types into src/core/types.ts.
70bd843
@benjamn
Infer better refetchQueries return type from onQueryUpdated return type.
b75bd7d
@benjamn benjamn requested a review from hwillson July 28, 2021 16:57
hwillson
hwillson approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOOHOO!!! 🎉 🎉 🎉

@benjamn benjamn merged commit b0da267 into main Jul 28, 2021
@benjamn benjamn deleted the release-3.4 branch July 28, 2021 17:12
@benjamn
Copy link
Member Author

benjamn commented Jul 28, 2021

@abdonrd You have uncanny timing! The final @apollo/client@3.4.0 has now been published to npm, though it's tagged as next rather than latest for the meantime. Let us know if you have any problems with it, and thanks again for all your help with this release!

@benjamn benjamn restored the release-3.4 branch July 28, 2021 17:17
@ajgassner ajgassner mentioned this pull request Jul 28, 2021
Closed
@benjamn benjamn mentioned this pull request Jul 28, 2021
Merged
@hwillson hwillson moved this from In progress to Done in Release 3.4 Jul 29, 2021
@hwillson hwillson removed this from the MM-2021-07 milestone Jul 29, 2021
@brainkim brainkim deleted the release-3.4 branch August 13, 2021 14:34
@brainkim brainkim restored the release-3.4 branch August 13, 2021 14:34
@benjamn benjamn mentioned this pull request Oct 1, 2021
Closed
@StephenBarlow StephenBarlow deleted the release-3.4 branch October 4, 2021 19:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hwillson hwillson hwillson approved these changes

@StephenBarlow StephenBarlow StephenBarlow approved these changes

Assignees

@benjamn benjamn

@brainkim brainkim

@jcreighton jcreighton

Labels
🧶 minor-release 🚀 shipped
Projects
No open projects
Release 3.4
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet