Separate parsing and normalization #2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the BufferedSource version
__typename needs to happen first
THey were relying on the Json containing "id" but if we use the models as source of truth, that doesn't work anymore
It's not needed anymore since we don't normalize while parsing anymore
martinbonnin
commented
Jan 6, 2021
| val data = operation.adapter().fromResponse(responseReader, null) | ||
| val records = operation.normalize(data, customScalarAdapters, networkResponseNormalizer() as ResponseNormalizer<Map<String, Any>?>) |
There was a problem hiding this comment.
Since we always use neworkResponseNormalizer here, we can remove the parameter and do other cleanups. I didn't do them yet in order to not clash with #2839
martinbonnin
commented
Jan 6, 2021
| builder<D>(operation) | ||
| .data(data) | ||
| .fromCache(true) | ||
| .dependentKeys(responseNormalizer.dependentKeys()) | ||
| .dependentKeys(records.dependentKeys()) // Do we need the dependentKeys here? |
There was a problem hiding this comment.
Is there a specific reason why we would need the dependent keys when reading from the cache?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove normalization from the parsing step. Normalization is now done from the models, like it is done when using the cache write APIs.
Advantages:
ApolloStore#writeAndPublishoverwrites cache entries when using fragments聽#2818)This also enables the streaming parser in
ApolloParseInterceptor, which is the main use case, which is something like ~25% faster on the whole parsing + normalization path, potentially event faster without normalization 馃帀 (see the README.md in the benchmarks for actual numbers)