Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate parsing and normalization #2841

Merged
merged 13 commits into from
Jan 7, 2021
Merged

Separate parsing and normalization #2841

merged 13 commits into from
Jan 7, 2021

Commits on Jan 6, 2021

  1. separate response normalization from parsing

    @martinbonnin
    martinbonnin committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    5ee98ea View commit details
    Browse the repository at this point in the history

  2. fix SimpleOperationResponseParser when data is null

    @martinbonnin
    martinbonnin committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    a112e73 View commit details
    Browse the repository at this point in the history

  3. add a parse overload that takes a String and delegate all overloads to 

    the BufferedSource version
    @martinbonnin
    martinbonnin committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    241bfd2 View commit details
    Browse the repository at this point in the history

  4. use operation.parse directly from integration tests

    @martinbonnin
    martinbonnin committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    6d04596 View commit details
    Browse the repository at this point in the history

  5. remove unused method

    @martinbonnin
    martinbonnin committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    20db081 View commit details
    Browse the repository at this point in the history

  6. honor @skip/@include when writing to the cache

    @martinbonnin
    martinbonnin committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    dfd74a1 View commit details
    Browse the repository at this point in the history

  7. fix test fixture 

    __typename needs to happen first
    @martinbonnin
    martinbonnin committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    2651248 View commit details
    Browse the repository at this point in the history

  8. Fix cache tests that where not querying "id" 

    THey were relying on the Json containing "id" but if we use the models
as source of truth, that doesn't work anymore
    @martinbonnin
    martinbonnin committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    e3fac86 View commit details
    Browse the repository at this point in the history

  9. use the String version of BigDecimal so that parsing/normalization is 

    idempotent
    @martinbonnin
    martinbonnin committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    1b825bd View commit details
    Browse the repository at this point in the history

  10. put __typename first

    @martinbonnin
    martinbonnin committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    c906632 View commit details
    Browse the repository at this point in the history

  11. fix tests: query for Ids

    @martinbonnin
    martinbonnin committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    7ddad50 View commit details
    Browse the repository at this point in the history

  12. remove ResolveDelegate from RealResponseReader 

    It's not needed anymore since we don't normalize while parsing anymore
    @martinbonnin
    martinbonnin committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    93e68e0 View commit details
    Browse the repository at this point in the history

  13. update Benchmarks

    @martinbonnin
    martinbonnin committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    cb747b7 View commit details
    Browse the repository at this point in the history