Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address memory leak in ApolloServerPluginUsageReporting #7662

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

trevor-scheer
Copy link
Member

WIP attempt to address #7639

@netlify
Copy link

netlify bot commented Jul 24, 2023

Deploy Preview for apollo-server-docs ready!

Name Link
🔨 Latest commit 6f3412b
🔍 Latest deploy log https://app.netlify.com/sites/apollo-server-docs/deploys/64beea22666acf0008443087
😎 Deploy Preview https://deploy-preview-7662--apollo-server-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6f3412b:

Sandbox Source
Apollo Server Typescript Configuration
Apollo Server Configuration

@trevor-scheer
Copy link
Member Author

@gabotechs based on the Request object you shared, it looks like this is what's leaking (though it's not obvious to me why). This is the only request we send and the URL matches from your object.

Are you able to test out a build from this PR for me and see if the issue goes away?

npm i https://pkg.csb.dev/apollographql/apollo-server/commit/6f3412bd/@apollo/server

I grabbed this URL from the codesandbox link in the comment above. If you're using any other packages from this monorepo it would be preferable to grab them all in the same manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant