Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address memory leak in ApolloServerPluginUsageReporting #7662

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Address memory leak in ApolloServerPluginUsageReporting #7662

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/server/src/plugin/usageReporting/plugin.ts
View file
Open in desktop
Expand Up @@ -313,7 +313,7 @@ export function ApolloServerPluginUsageReporting<TContext extends BaseContext>(

// Wrap fetcher with async-retry for automatic retrying
const fetcher: Fetcher = options.fetcher ?? fetch;
const response: FetcherResponse = await retry(
let response: FetcherResponse | null = await retry(
// Retry on network errors and 5xx HTTP
// responses.
async () => {
Expand Down Expand Up @@ -401,6 +401,7 @@ export function ApolloServerPluginUsageReporting<TContext extends BaseContext>(
if (options.debugPrintReports) {
logger.info(`Apollo usage report: status ${response.status}`);
}
response = null;
};

requestDidStartHandler = ({
Expand Down