Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(composition): Remove composition responsibilities from supergraph printer #1000

Merged
merged 5 commits into from
Sep 3, 2021

Conversation

trevor-scheer
Copy link
Member

@trevor-scheer trevor-scheer commented Sep 2, 2021

Push schema construction responsibilities up and out of the supergraph printer and into composition where they belong.

  • Update tests (sort related)
  • Fix incorrect test for printFederatedSchema (exposed by an unexpected test update)

I encountered these issues during implementation for #996 and figured this work was a separate issue and worth breaking out. #996 will be based against this branch.

of the subgraph printer and up into composition
where they belong.

Resolve the issues that follow.
* Update tests (sort related)
* Fix incorrect test for printFederatedSchema
Copy link
Contributor

@martijnwalraven martijnwalraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Moving responsibilities out of printing nicely cleans things up.

federation-js/src/service/printSubgraphSchema.ts Outdated Show resolved Hide resolved
@trevor-scheer trevor-scheer merged commit 71e0dd1 into main Sep 3, 2021
@trevor-scheer trevor-scheer deleted the trevor/fix-printer-responsibilities branch September 3, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants