chore(federation): Update schema printers #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevor-scheer
force-pushed
the
trevor/update-schema-printers
branch
from
5fdc254
to
c524cda
Compare
|
Needs changelog entry |
martijnwalraven
approved these changes
Sep 2, 2021
There was a problem hiding this comment.
Thanks for tackling this! I don't have any real feedback on these changes in particular. Some changes seem unrelated to the @specifiedBy/@deprecated additions, but I'm assuming that's because you're brought the code up to date with graphql-js v16.
We've talked about this before, but it's a shame we have to fork printSchema (and do it twice!). This is probably a good topic for discussion with @IvanGoncharov, but it would be great to investigate additions to graphql-js that could avoid the need for forking altogether.
trevor-scheer
force-pushed
the
trevor/update-schema-printers
branch
from
96d073d
to
d0eb6f7
Compare
trevor-scheer
changed the base branch from
main
to
trevor/fix-printer-responsibilities
martijnwalraven
approved these changes
Sep 3, 2021
trevor-scheer
commented
Sep 3, 2021
Comment on lines
+521
to
+522
| // Apollo addition: support both specifiedByUrl and specifiedByURL - these | ||
| // happen across v15 and v16. |
There was a problem hiding this comment.
@IvanGoncharov do you intend to preserve this breaking change in v16?
graphql/graphql-js#3156
Add tests for printing @SpecifiedBy and deprecated input values.
trevor-scheer
force-pushed
the
trevor/update-schema-printers
branch
from
699056d
to
f3368e2
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update our subgraph and supergraph schema printers to match the
printSchemafunction fromgraphql-jsas closely as possible. This introduces printing capabilities for the@specifiedBydirective as well as@deprecatedon input values.This PR depends on #1000 which resolves a few problems I turned up after addressing @martijnwalraven's sorting concern.
lexicographicSortSchemawas being called, but the printer was modifying the schema after that sort).printFederatedSchematest was testing printing a composed graph rather than a subgraph, so I fixed the test.printFederatedSchema(which was exported asprintSchema) toprintSubgraphSchemato prevent naming confusion.Fixes #994
Fixes #635
Post-merge edit: In addition, this PR now prints interfaces implementing interfaces (as a byproduct of updating our printer forks). Previously it used to ignore them.