Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publishing process to include dist directory #2583

Merged
merged 1 commit into from May 17, 2023

Conversation

trevor-scheer
Copy link
Member

My PR #2559 removed a postinstall build step which our publish action depended on. This replaces the missing build step.

This unfortunately resulted in a botched release of v2.4.4 where none of the packages are built. This includes a changeset to patch releases all of the packages, and the v2.4.4 versions will be deprecated.

My PR #2559 removed a postinstall build step which our publish
action depended on. This replaces the missing build step.
@trevor-scheer trevor-scheer requested a review from a team as a code owner May 17, 2023 01:03
@changeset-bot
Copy link

changeset-bot bot commented May 17, 2023

🦋 Changeset detected

Latest commit: f0a7169

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@apollo/composition Patch
apollo-federation-integration-testsuite Patch
@apollo/gateway Patch
@apollo/federation-internals Patch
@apollo/query-graphs Patch
@apollo/query-planner Patch
@apollo/subgraph Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for apollo-federation-docs canceled.

Name Link
🔨 Latest commit f0a7169
🔍 Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/646427fe855b1c0008cd6aaf

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@trevor-scheer trevor-scheer merged commit c96e24c into main May 17, 2023
15 checks passed
@trevor-scheer trevor-scheer deleted the trevor/fix-publish branch May 17, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant